Skip to content
This repository was archived by the owner on Apr 12, 2019. It is now read-only.

fix bug when get tag id #147

Merged
merged 3 commits into from
Mar 2, 2019
Merged

fix bug when get tag id #147

merged 3 commits into from
Mar 2, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 1, 2019

This will fix go-gitea/gitea#5585

It seems

git show-ref --tags <tag>

will not give the right commit id of this tag, but

git rev-list -n 1 $TAG

will return the right commit id.

@lunny lunny added the kind/bug label Mar 1, 2019
@codecov-io
Copy link

codecov-io commented Mar 1, 2019

Codecov Report

Merging #147 into master will decrease coverage by 1.37%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #147      +/-   ##
=========================================
- Coverage   37.28%   35.9%   -1.38%     
=========================================
  Files          28      28              
  Lines        1832    1838       +6     
=========================================
- Hits          683     660      -23     
- Misses       1055    1089      +34     
+ Partials       94      89       -5
Impacted Files Coverage Δ
repo_commit.go 24.72% <0%> (-0.56%) ⬇️
repo_tag.go 36.36% <100%> (+4.04%) ⬆️
tag.go 10.86% <0%> (-58.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e03eb39...fa27770. Read the comment docs.

@lunny
Copy link
Member Author

lunny commented Mar 1, 2019

@thibaultmeyer could you confirm this will fix your issue?

@lunny lunny merged commit 8983773 into go-gitea:master Mar 2, 2019
@lunny lunny deleted the lunny/fix_get_tag_commit_id branch March 2, 2019 01:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong commit Id after creating a release on existing tag
5 participants