This repository was archived by the owner on Apr 12, 2019. It is now read-only.
Fix tree entry parsing #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
approved these changes
Feb 9, 2018
lunny
suggested changes
Feb 9, 2018
tree.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| for _, entry := range t.entries { |
There was a problem hiding this comment.
A second traversing is unnecessary.
There was a problem hiding this comment.
Maybe a method named ParseEntries of tree is better?
lunny
approved these changes
Feb 10, 2018
|
Please update gitea dep |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the parsing of filenames with escaped characters, which did not previously handled escaped characters such as
\ncorrectly. Also adds unit tests.This PR also exposes the parsing functionality as public, so that it can be reused (see https://github.com/go-gitea/gitea/blob/a89592d4abfef01e68e3c53a3cdb3846b03abd2b/models/repo_indexer.go#L234)