Skip to content
This repository was archived by the owner on Dec 2, 2017. It is now read-only.

Changes for latest DroneCI #146

Merged
merged 1 commit into from
Sep 7, 2017
Merged

Changes for latest DroneCI #146

merged 1 commit into from
Sep 7, 2017

Conversation

tboerger
Copy link
Member

Before we can merge that Drone have to be updated and the secrets have to be defined.

@appleboy
Copy link
Member

LGTM

.drone.yml Outdated
clone:
git:
image: plugins/git:latest
depth: 50
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not depth: 1 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, I can also do depth 1... I just copied that part from go-gitea/gitea since it had been there like that as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, if we ever wanna do git diff --numstat master..HEAD for speeding up tests we might want depth: 50 🤔

.drone.yml Outdated
path: src

clone:
git:
image: plugins/git:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can ignore :latest since the default behavior is to download the latest tag.

@tboerger tboerger force-pushed the drone-upgrade branch 3 times, most recently from 0315d59 to 0e35d10 Compare September 7, 2017 10:34
@tboerger
Copy link
Member Author

tboerger commented Sep 7, 2017

Forced to merge it as it is, otherwise the builds are broken because of Drone upgrade to 0.8

@tboerger tboerger merged commit c844513 into master Sep 7, 2017
@tboerger tboerger deleted the drone-upgrade branch September 7, 2017 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants