This repository was archived by the owner on Dec 2, 2017. It is now read-only.
Build caddy with plugins via multi-stage #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appleboy
approved these changes
Jun 6, 2017
|
LGTM |
|
LGTM |
|
Have we changed drone to 0.6 now? |
|
@lunny No. still needs to update drone sig file. |
Signed-off-by: Kim "BKC" Carlbäcker <[email protected]>
|
Does this work with the docker-version we have on demo? (v1.13.1 API 1.26) |
bkcsoft
suggested changes
Jun 8, 2017
| && sed -i '/This is where other plugins get plugged in (imported)/a _ "github.com/simia-tech/caddy-locale"' caddymain/run.go \ | ||
| && go install -v . \ | ||
| && /go/bin/caddy -version | ||
|
|
||
| FROM alpine:edge |
There was a problem hiding this comment.
Does docker v1.13.1 have support for multi-image?
There was a problem hiding this comment.
(anyone can dismiss this review if this does work...)
There was a problem hiding this comment.
We only need Docker > 17.05 for building but the resulting image is compatible with any old version (only the last image is kept). This function permit to use a builder pattern in one Dockerfile (with possible multi-builder).
There was a problem hiding this comment.
For confirmation, this is already in production on https://gitea.io with the same solution.
bkcsoft
approved these changes
Jun 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as go-gitea/website#43 + go-gitea/website#45
This will need a new drone sig (cc @lunny @appleboy and anyone who can sign ^^)
Fix #120