Merge pull request #48 from greut/flush-then-close

fix: last line is never sent

Author: daniel-nichter

cmd.go

@@ -334,6 +334,8 @@ func (c *Cmd) run(in io.Reader) {
 	// who's waiting for us to close them.
 	if c.stdoutStream != nil {
 		defer func() {
+			c.stdoutStream.Flush()
+			c.stderrStream.Flush()
 			// exec.Cmd.Wait has already waited for all output:
 			//   Otherwise, during the execution of the command a separate goroutine
 			//   reads from the process over a pipe and delivers that data to the
@@ -643,3 +645,11 @@ func (rw *OutputStream) SetLineBufferSize(n int) {
 	rw.bufSize = n
 	rw.buf = make([]byte, rw.bufSize)
 }
+
+// Flush empties the buffer of its last line.
+func (rw *OutputStream) Flush() {
+	if rw.lastChar > 0 {
+		line := string(rw.buf[0:rw.lastChar])
+		rw.streamChan <- line
+	}
+}

cmd_test.go

@@ -560,7 +560,7 @@ func TestStreamingMultipleLines(t *testing.T) {
 	}
 
 	// Write two short lines
-	input := "foo\nbar\n"
+	input := "foo\nbar"
 	n, err := out.Write([]byte(input))
 	if n != len(input) {
 		t.Errorf("Write n = %d, expected %d", n, len(input))
@@ -582,6 +582,8 @@ func TestStreamingMultipleLines(t *testing.T) {
 		t.Errorf("got line: '%s', expected 'foo'", gotLine)
 	}
 
+	out.Flush()
+
 	// Get next line
 	select {
 	case gotLine = <-lines: