Minutes: GitHub Review Meetings [every Thursday]

[moul]

Longterm issue to keep track of discussions and PRs related to the GitHub Review Meetings.

Instructions: https://github.com/gnolang/meetings#weekly-review-meeting

Ideas

• write a script making lists of issues/PRs with useful metrics (amount of changes, amount of comments, age, stale score, amount of dependents, etc) to ease choosing the best topics.
• write a script making lists of issues/PRs to generate public reports.
• consider having templated/canned answers and more labels, to make the review process faster and more consistent (maybe a bad idea).

[moul]

Session 1 -- Jul, 27th 2023

Experimental session, we managed to discuss ~5 PRs, worked on improving labels and pipeline, and discussed more in details about the concept of memPkg VS Dir VS fs package.

Updated PRs & issues:

• feat: implement gno mod init command gno#955
• feat(repl): support multi-line inputs and declarations gno#978
• chore(deps): bump golang.org/x/mod from 0.9.0 to 0.12.0 gno#953
• chore: update gitpod configuration gno#987
• feat: fix gno test for _test.gno and _filetest.gno files gno#945
• feat: add r/gnoland/pages gno#874
• fix(gnovm): correctly update refs count when self-assigning gno#960
• fix(gnovm): PrevRealm in _test files gno#896
• feat: initial 'gno lint' gno#981
• chore(deps): bump google.golang.org/protobuf from 1.27.1 to 1.31.0 gno#942
• Banker should use PrevRealm instead of OrigPkgAddr gno#986

[moul]

Session 2 -- Aug, 3rd 2023

Updated PRs & issues:

• WIP: tm2 clean up gno#825 (comment) -- needs rebase + changes to make the CI green.
• fix(gnovm): PrevRealm in _test files gno#896 (review) -- small details, then good
• feat: add file-based transaction indexing gno#546 -- summon @jaekwon
• fix(gnovm): correctly update refs count when self-assigning gno#960 -- changes requested, regarding the file structure.
• feat: fix gno test for _test.gno and _filetest.gno files gno#945 -- identified as gnopher-hole (Gnopher hole: Module VS Pkg VS Path VS Dir VS SubPkg VS SubModule VS SubDir VS SubPath ... gno#1024 2^10 :p)

[harry-hov]

Session 3 -- Aug, 10th 2023

Updated PRs & issues:

• feat: use PackageClauseOnly for parsing pkg name gno#994 -- merged + comment for the future.
• feat: make gnovm wasm-friendly gno#1012 -- merged + comment for the future.
• docs: bootstrap a glossary, with p/ and r/ gno#1043 -- merged.
• feat(repl): Add support for new declarations. gno#1044 -- new comment.
• test(gnovm): "*_filetest.gno" instructions gno#1023 -- changes requested.
• chore(deps): bump github.com/mattn/go-runewidth from 0.0.14 to 0.0.15 gno#1003 -- merged.
• feat: fix gno test for _test.gno and _filetest.gno files gno#945 -- merged.

[zivkovicmilos]

Session 4 -- Aug, 17th 2023

---

Updated PRs & issues:

• feat: add UI components gno#781 -- marked as draft + left comments.
• fix: correct panic message for ParseMemPackage() gno#1052 -- merged.
• docs(gnovm): gno test help long description gno#1010 -- merged.
• test(gnovm): fix TestPackages gno#964 -- merged.
• refactor(gnovm): make IsOriginCall/AssertOriginCall rely on PrevRealm gno#1048 -- reviewed, pending CI fixes.
• fix(gnovm): correctly update refs count when self-assigning gno#960 -- marked as draft + left comments.

[thehowl]

Session 5 -- Aug, 24th 2023

Updated PRs & issues:

• chore(tests): don't panic on diff output gno#660 -- commented
• chore(vscode): associate .gno files with Go syntax gno#832 -- close
• chore: use std.PrevRealm() in grc721 package gno#992 -- needs further discussion (cc/ @piux2 to open a related RFC issue)

Also discussed: possibility to improve meeting by also doing a filtering/labeling/triaging part (on input of @piux2 @mvertes), including issues. This is also in light of conversation to better prioritise what we need in order to reach mainnet.

[moul]

Session 6 -- Aug, 31st 2023

Updated PRs & issues:

• refactor: tm2 clean up against the latest main branch gno#1080 -- discussed, merged
• feat: gno test support /... pattern gno#1078
• feat: use modfile package to write modfile gno#1077
• fix(pkg/commands): readPassword support for windows gno#1089 -- merged
• feat: add file-based transaction indexing gno#546 -- postponed (depends on @jaekwon)
• fix(mempkg): don't attempt to validate name of an empty package gno#1076 -- additional comments

Also discussed:

• Using a new kanban workflow for triage (issues & PRs) -> PoC here: 🚀 The Launch [DEPRECATED]

[thehowl]

Session 7 -- Sep, 7th 2023

Updated PRs & issues:

• feat(stdlibs/std)!: namespace minted coins with realm path gno#875 (review) -- reviewed & commented
• fix: panic in store.SprintStoreOps gno#1036 -- merged
• docs: add first documentation archetype. gno#957 -- closed, redirected to new PR
• refactor(gnovm): make IsOriginCall/AssertOriginCall rely on PrevRealm gno#1048 -- commented, discussed