Skip to content

make .bat and .cmd files work for editors on windows #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

pm100
Copy link
Contributor

@pm100 pm100 commented Apr 12, 2023

This Pull Request fixes/closes #1316

if command launch on windows fails then retry doing

cmd /C <editor> <file name>

verified that it fixed vim (original bug) plus code (added by commenter)

it is arguable that the rust core code should do this, they get close but are not quite there

I followed the checklist:

  • I added unittests
  • [x ] I ran make check without errors
  • [ x] I tested the overall application
  • I added an appropriate item to the changelog

@pm100 pm100 changed the title make .bat and .cmd files work for editors make .bat and .cmd files work for editors on windows Apr 13, 2023
@extrawurst
Copy link
Collaborator

Is there a way to add a test for this?

@pm100
Copy link
Contributor Author

pm100 commented Apr 15, 2023

Is there a way to add a test for this?

Thanks for twisting my arm into doing that

  • I found many odd quirks in my implementation. I hesitate to use the word 'bug' :-)
  • I learned a huge amount about rust testing

Gonna pull the PR while I tweak

@pm100 pm100 closed this Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vim is not available as external editor on windows
2 participants