Skip to content

Generate rust toolchain file #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 25, 2022

Conversation

SergioRibera
Copy link
Contributor

This PR is to add the rust-toolchain file that allows all those who want to contribute or run the project to do it under the same version of Rust

It changes the following:

  • Add rust-toolchain file

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@extrawurst
Copy link
Collaborator

extrawurst commented Oct 20, 2022

I cannot merge this. this overrides the toolchains in CI:

Screenshot 2022-10-20 at 19 14 33

this is the 1.60 pipeline suddenly using stable too

@SergioRibera
Copy link
Contributor Author

SergioRibera commented Oct 21, 2022

Hey, i'll done, you can see now the CI can be override the rust toolchain file

Note: sorry for the other edited files, it's because of an rebase I made

@extrawurst
Copy link
Collaborator

can you please rebase/squash? I see all kinds of diffs in here that do not belong

@SergioRibera
Copy link
Contributor Author

@extrawurst Done 😃

@extrawurst extrawurst merged commit e5acee1 into gitui-org:master Oct 25, 2022
@extrawurst
Copy link
Collaborator

Thanks! ❤️

IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this pull request Jun 4, 2024
* Generate rust toolchain file
* Make track "stable" channel
* CD workflow override rust toolchain file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants