-
-
Notifications
You must be signed in to change notification settings - Fork 610
Add notification when correctly copying hash commit #1376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notification when correctly copying hash commit #1376
Conversation
I also ran into these usability issues with copying. Maybe it would be useful to display the text that was copied in the notification? Additionally, copying might fail (e.g. if both xclip and xsel are missing or if gitui is being run via ssh). The notification could report that failure instead when it happens. Maybe a good place to catch that error is at the call site of |
You are very right, I think it would be very useful to know what text is being copied, on the other hand I also agree with you, I think it is useful to show the error message if the copy fails, in that case I did nothing because I did not know what to do with that error, now I have an idea, so I will be making changes and will update the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
please rebase/squash so I can merge it |
oh and please fix clippy :) |
@extrawurst That's it, I fixed all the clippy and formatting errors in the project (I think it should go in another PR but the CI was not working due to some base errors) If you need any changes, please let me know |
I am so sorry I only meant the changes for stable clippy, you are right the remaining stuff should and IS in another PR already: #1390 |
#1390 is merged now, so please update with current master again |
747bc80
to
fefd64a
Compare
@extrawurst Done, now a query please, what version of rust do you use? |
Please rebase again and resolve the conflicts so we can merge this |
please fix the clippy errors |
@extrawurst Done 😃 |
Thanks for sticking at this! |
This Pull Request fixes/closes #1160.
It changes the following:
I followed the checklist:
make check
without errors