Skip to content

install ordereddict only on 2.6 with wheel #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2016

Conversation

graingert
Copy link
Contributor

No description provided.

@Byron
Copy link
Member

Byron commented Sep 24, 2016

@graingert Thanks for your contribution! It's much appreciated, as I would like to get onto wheels too! Unfortunately the build fails, here is the error-log. In case you get to it this weekend, it would be much appreciated, otherwise I'd try to mechanically fix the linter issues, even though I don't understand what the code actually does.

@Byron Byron added this to the v2.0.9 - Bugfixes milestone Sep 24, 2016
@Byron
Copy link
Member

Byron commented Oct 1, 2016

Alright, here is the patch to pass the linter:

diff --git a/setup.py b/setup.py
index 15e4571..35b1115 100755
--- a/setup.py
+++ b/setup.py
@@ -9,6 +9,8 @@ except ImportError:

 from distutils.command.build_py import build_py as _build_py
 from setuptools.command.sdist import sdist as _sdist
+import pkg_resources
+import logging
 import os
 import sys
 from os import path

However, I realize that I don't understand the added special cases very much. Can you give me a little more context on the problem you ran into that this patch fixes ?

@graingert
Copy link
Contributor Author

This means that python 2.6 will be able to use wheels because they don't run the setup.py

@graingert
Copy link
Contributor Author

I've allowed edits from maintainers on this branch

@Byron Byron merged commit 4572ffd into gitpython-developers:master Oct 1, 2016
@graingert graingert deleted the patch-2 branch October 1, 2016 12:28
@Byron
Copy link
Member

Byron commented Oct 1, 2016

Alright, it's merged. Thanks for your contribution !
In an ideal world, this rather messy setup.py would not be needed, even though by now I learned to live with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants