FIx issues with components startup #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusludmann
approved these changes
Jun 1, 2022
Pothulapati
force-pushed
the
tar/pods-start
branch
from
29c1e85 to
b453362
Compare
At this point, All the pods startup correctly and the DNS stuff is left to be figured out. To not waste too much time, I've moved to use `cert-manager` but it can be replaced in a separate PR and this way we are not wasting time on it now. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
force-pushed
the
tar/pods-start
branch
from
b453362 to
4f778cf
Compare
Signed-off-by: Tarun Pothulapati <[email protected]>
Signed-off-by: Tarun Pothulapati <[email protected]>
Signed-off-by: Tarun Pothulapati <[email protected]>
Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
force-pushed
the
tar/pods-start
branch
from
7992b05 to
f1ef54a
Compare
Signed-off-by: Tarun Pothulapati <[email protected]>
Signed-off-by: Tarun Pothulapati <[email protected]>
Signed-off-by: Tarun Pothulapati <[email protected]>
Signed-off-by: Tarun Pothulapati <[email protected]>
Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
force-pushed
the
tar/pods-start
branch
from
1e46792 to
3dfbe2b
Compare
|
The hard override of the |
Pothulapati
commented
Jun 7, 2022
Pothulapati
commented
Jun 7, 2022
| @@ -37,7 +39,7 @@ fi | |||
|
|
|||
| mount --make-shared /sys/fs/cgroup | |||
| mount --make-shared /proc | |||
| mount --make-shared /var/gitpod | |||
| mount --make-shared /var/gitpod/workspaces | |||
There was a problem hiding this comment.
This was done intentionally, as I wanted to output the root cert into /var/gitpod/gitpod-ca.crt and workspaces folder felt specific to workspaces (updated README around this) WDYT @csweichel ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At this point, All the pods startup correctly and the
DNS stuff is left to be figured out.
To not waste too much time on a specific cert issue
(that prevented
ws-daemonfrom starting up),I've moved to use
cert-managerbut it can be replacedin a separate PR. This should be a simple change
and gives us time to focus on the important DNS stuff.
Signed-off-by: Tarun Pothulapati [email protected]
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation