Skip to content

Switch workbench preferred color themes to Gitpod Light/Dark #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

Shulammite-Aso
Copy link

@Shulammite-Aso Shulammite-Aso commented Nov 9, 2021

This PR fixes gitpod-io/gitpod#6403

@Shulammite-Aso
Copy link
Author

Hi @gtsiolis @akosyakov @jeanp413 please have a look

@jeanp413
Copy link
Member

@Shulammite-Aso you should also set "window.autoDetectColorScheme": true so that workbench.preferredLightColorTheme and workbench.preferredDarkColorTheme take effect.

@Shulammite-Aso
Copy link
Author

@Shulammite-Aso you should also set "window.autoDetectColorScheme": true so that workbench.preferredLightColorTheme and workbench.preferredDarkColorTheme take effect.

Okay, i guess on the same block right?

@Shulammite-Aso
Copy link
Author

Just made the update @jeanp413

@akosyakov
Copy link
Member

@jeanp413 I don't think we need to change window.autoDetectColorScheme. It is more like if a user enables it then it should use gitpod themes by default, but we should restrain from changing defaults otherwise.

@jeanp413
Copy link
Member

jeanp413 commented Nov 10, 2021

@akosyakov Good point, but right now we don't sync user theme set in the dashboard to the editor so it will keep using the Light theme regardless of what the user sets in his settings. There's this issue gitpod-io/gitpod#3982 but got closed because it was stale

@akosyakov
Copy link
Member

@jeanp413 It was discussed internally that we don't do synching between dashboard and editor: https://gitpod.slack.com/archives/C01KGM9BH54/p1635256498135500?thread_ts=1635187855.111600&cid=C01KGM9BH54

@jeanp413
Copy link
Member

@Shulammite-Aso I will revert the last commit, rebase and then merge. Thanks

@jeanp413 jeanp413 merged commit 802b785 into gitpod-io:gp-code/main Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants