Skip to content

[bitbucket-server] handle pull-request context url #9524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2022
Merged

[bitbucket-server] handle pull-request context url #9524

merged 1 commit into from
Apr 25, 2022

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Apr 25, 2022 •
edited by jldec
Loading

This PR adds support for Pull Request context URLs.

Part of #8499
Resolves #9011

How to test

  • Prepend a PR of a BBS with this preview environment location, e.g. https://at-bbs.staging.gitpod-dev.com/#https://bitbucket.gitpod-self-hosted.com/projects/FOO/repos/repo123/pull-requests/1/overview
    Screen Shot 2022-04-25 at 13 32 55

Release Notes

[Bitbucket-Server] handle Pull Request context URLs
  • /werft with-clean-slate-deployment

@AlexTugarev AlexTugarev mentioned this pull request Apr 25, 2022
Closed
@AlexTugarev
Copy link
Member Author

AlexTugarev commented Apr 25, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-at-bbs.30
(with .werft/ from main)

@AlexTugarev AlexTugarev marked this pull request as ready for review April 25, 2022 11:33
@AlexTugarev AlexTugarev requested a review from a team April 25, 2022 11:33
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 25, 2022
jldec
jldec approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@jldec jldec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/hold in case you'd like someone to look more deeply at the code

tested with https://at-bbs.staging.gitpod-dev.com/#https://bitbucket.gitpod-self-hosted.com/projects/JLDEC/repos/test123/pull-requests/1/overview

opened workspace on the right branch.

Screenshot 2022-04-25 at 12 48 58

(unable to test git push with our current BBS self-hosted instance)

geropl
geropl approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code, LGTM!

/unhold

@roboquat roboquat merged commit 0c11cdc into main Apr 25, 2022
@roboquat roboquat deleted the at/bbs branch April 25, 2022 15:08
@jldec jldec mentioned this pull request Apr 25, 2022
Closed
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jldec jldec jldec approved these changes

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bitbucket Server] Support for PR Contexts
4 participants
@AlexTugarev @jldec @geropl @roboquat