Skip to content

[jb] allow to specify plugins per a product #9445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2022
Merged

[jb] allow to specify plugins per a product #9445

merged 1 commit into from
Apr 21, 2022

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Apr 21, 2022 •
edited
Loading

Description

JB plugins are often are product specific. Although it makes sense to configure some plugins which should be installed for all products it is better to allow installation of plugins per a concrete product like here.

Related Issue(s)

Fixes #

How to test

Release Notes

Allow to configure JB plugins on repo level per a product, i.e. specific for IntelliJ or GoLand.

Documentation

@akosyakov akosyakov marked this pull request as ready for review April 21, 2022 08:25
@akosyakov akosyakov requested review from a team April 21, 2022 08:25
@github-actions github-actions bot added team: IDE team: webapp Issue belongs to the WebApp team labels Apr 21, 2022
@akosyakov akosyakov force-pushed the akosyakov/improve-importing-indexing-6740 branch 3 times, most recently from 1e6f948 to f5b8dd3 Compare April 21, 2022 08:27
@akosyakov
Copy link
Member Author

akosyakov commented Apr 21, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-akosyakov-improve-importing-indexing-6740.4

@akosyakov akosyakov marked this pull request as draft April 21, 2022 09:29
@akosyakov akosyakov force-pushed the akosyakov/improve-importing-indexing-6740 branch 3 times, most recently from dff4a59 to 7091687 Compare April 21, 2022 09:40
@akosyakov akosyakov force-pushed the akosyakov/improve-importing-indexing-6740 branch from 7091687 to c1d7453 Compare April 21, 2022 12:11
@akosyakov akosyakov marked this pull request as ready for review April 21, 2022 12:19
@geropl geropl self-assigned this Apr 21, 2022
geropl
geropl approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that workspace started, code LGTM

Did not test the Intellij and whether the plugin is actually installed.

@roboquat roboquat merged commit 9cbc72a into main Apr 21, 2022
@roboquat roboquat deleted the akosyakov/improve-importing-indexing-6740 branch April 21, 2022 13:39
filiptronicek
filiptronicek reviewed Apr 21, 2022
View reviewed changes
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit late, but also tested and works fine image

@loujaybee loujaybee mentioned this pull request Apr 21, 2022
Closed
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiptronicek filiptronicek filiptronicek left review comments

@andreafalzetti andreafalzetti andreafalzetti approved these changes

@geropl geropl geropl approved these changes

Assignees

@geropl geropl

Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/L team: IDE team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akosyakov @andreafalzetti @filiptronicek @geropl @roboquat