Skip to content

Refresh web page when instanceId changed #8978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

mustard-mh
Copy link
Contributor

Description

#8226 (comment) Option3 with refresh page

Refresh web page when instanceId changed to get ide config again

Related Issue(s)

Fixes #8226

How to test

  1. Start a workspace A (ie. browser IDE only) in tab 1
  2. Go to Dashboard in tab2 to stop A, go to Preferences to choose one desktop IDE, and re-open A
  3. Note tab1 to see if display "Open in xxx"

Release Notes

Fix IDE options display incorrectly when restarting the workspace

Documentation

@akosyakov
Copy link
Member

akosyakov commented Mar 29, 2022

The page refresh was removed on purpose in the original PR. cc @geropl

@mustard-mh mustard-mh closed this Mar 30, 2022
@geropl
Copy link
Member

geropl commented Mar 31, 2022

@akosyakov Hm. But I wonder if this signal could be used to trigger the logic again that is currently only run "onload":

  • re-fetch options
  • reveal the IDE if running

This would fix the re-start case, which I (tried to 🙄 ) explain in #8226 👍

@mustard-mh I would want to avoid re-load (to not trigger a re-direct from ws-proxy, which in turns closes the redirect-loop again), but rather try to run it's code again.

@akosyakov
Copy link
Member

As far as I remember on stopping/stopped event IDE is unloaded any only reliable way to load it again is to reload the page. Maybe it can be improved.

@geropl
Copy link
Member

geropl commented Mar 31, 2022

As far as I remember on stopping/stopped event IDE is unloaded any only reliable way to load it again is to reload the page. Maybe it can be improved.

Hm, ok. Also, maybe re-loading is not as bad as I thought when
1.) we already are on the IDE url (as in this case)
2.) we already know the workspace is actually running and we're connected (as in this case)

@mustard-mh mustard-mh deleted the hw/fix-8226 branch May 10, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[supervisor] Ensure we fetch IDEOptions/desktopIDEConfig on re-start
4 participants