Ensure uncommitted changes are displayed in dashboard #8888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
princerachit
approved these changes
Mar 22, 2022
|
@csweichel @aledbf You were requested as reviewers because you are specified as reviewers for the ws-damon-api. Is there a specific reason for that or should we change it to team workspace? And change it for the other ws components as well? |
|
@Furisto up to @csweichel. I have no problems changing it to workspace team. |
|
The duplication of the |
|
/hold Need to check with Chris to see if we must do #9007 first |
|
Closed in favor of #9007 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure uncommitted changes are displayed in dashboard. When the workspace was restored from a backup and subsequently stopped, uncommitted changes were not displayed in the dashboard anymore. The reason was that the location we use to check for changes was incorrect, because we get the checkout location from the initializer and the backup initializer does not use git and hence cannot provide the checkout location.
The checkout location is now provided as part of the workspace init request.
Related Issue(s)
Fixes #7370
How to test
Notes for reviewers
It looks like bigger repositories like gitpod itself currently do not backup correctly in the preview environment (unreleated to my changes). I used this for testing.
Release Notes