Automatic rollout latest Jetbrains IDE #7684

iQQBot · 2022-01-19T11:12:31Z

Description

Automatic rollout latest Jetbrains IDE

Related Issue(s)

How to test

can't find the way to test

Release Notes

NONE

Documentation

codecov · 2022-01-19T15:58:15Z

Codecov Report

Merging #7684 (cd76a12) into main (92a9fd5) will increase coverage by 1.69%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            main    #7684      +/-   ##
=========================================
+ Coverage   8.68%   10.38%   +1.69%     
=========================================
  Files         33       18      -15     
  Lines       2325      992    -1333     
=========================================
- Hits         202      103      -99     
+ Misses      2119      888    -1231     
+ Partials       4        1       -3

Flag	Coverage Δ
components-gitpod-cli-app	`10.38% <ø> (ø)`
components-local-app-app-darwin-amd64	`?`
components-local-app-app-darwin-arm64	`?`
components-local-app-app-linux-amd64	`?`
components-local-app-app-linux-arm64	`?`
components-local-app-app-windows-386	`?`
components-local-app-app-windows-amd64	`?`
components-local-app-app-windows-arm64	`?`
installer-raw-app	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
installer/pkg/common/objects.go
components/local-app/pkg/auth/auth.go
installer/pkg/components/ws-manager/tlssecret.go
installer/pkg/components/ws-manager/configmap.go
...staller/pkg/components/ws-manager/networkpolicy.go
...components/ws-manager/unpriviledged-rolebinding.go
installer/pkg/components/ws-manager/deployment.go
installer/pkg/components/ws-manager/role.go
installer/pkg/common/ca.go
installer/pkg/common/common.go
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a9fd5...cd76a12. Read the comment docs.

akosyakov · 2022-01-19T16:18:40Z

How do we consume them from preferences? We could add a new checkbox EAP which toggles between released and latest? Corresponding to https://www.jetbrains.com/resources/eap/ as I can see EAP there also points to any latest version.

iQQBot · 2022-01-19T16:21:20Z

@akosyakov https://www.jetbrains.com/rider/nextversion/
EAPs are closed for a period of time, and each EAP has its own expiration date
This PR is currently only for automating the build of JetBrains IDE images, other features will be handled in a later PR

akosyakov · 2022-01-19T16:26:35Z

EAPs are closed for a period of time, and each EAP has its own expiration date

Yes, but they point to released version. I don't think it makes sense to reuse their terminology. Instead of introduction new from user perspective. Internally we can call it differently, i.e. latest.

This PR is currently only for automating the build of JetBrains IDE images, other features will be handled in a later PR

ok, so if GH actions are green then we can merge without verifying that images are working?

iQQBot · 2022-01-19T16:30:39Z

ok, so if GH actions are green then we can merge without verifying that images are working?

In fact, you'll see a green one during review, but the last build of it before merge will fail because we have to point the reference to the main branch, but no template workflow exists for the main branch before merge

In fact, you may not see the status because I remove the push from the trigger pattern before I prepare the merge, so it won't show up in this PR

iQQBot · 2022-01-19T17:02:39Z

@akosyakov Please review it

iQQBot · 2022-01-19T17:28:12Z

.github/workflows/code-nightly.yaml

+        with:
+          credentials_json: ${{ secrets.GCP_SA_KEY }}
+      - name: Set up Google Cloud SDK
+        uses: google-github-actions/setup-gcloud@v0


change it from master to v0 because I saw a attention on google-github-actions/setup-gcloud

Do not pin this action to @master, use @v0 instead. We are going to rename the branch to main in 2022 and this will break existing workflows. See Versioning for more information.

iQQBot · 2022-01-19T17:29:27Z

.github/workflows/code-nightly.yaml

@@ -13,12 +13,14 @@ jobs:
      - uses: actions/checkout@v2
      - name: downlaod leeway
        run: cd /usr/bin && curl -fsSL https://github.com/gitpod-io/leeway/releases/download/v0.2.8/leeway_0.2.8_Linux_x86_64.tar.gz | sudo tar xz
-      - name: Set up Cloud SDK
-        uses: google-github-actions/setup-gcloud@master


Authentication inputs
⚠️ Deprecated: The following authentication inputs are deprecated and will be removed in a future release. See Authorization for more information.

iQQBot · 2022-01-19T17:32:06Z

.werft/build.yaml

@@ -166,6 +166,8 @@ pod:
        secretKeyRef:
          name: self-hosted
          key: segmentIOToken
+    - name: JAVA_HOME


move JAVA_HOME environment to here, in order to make github action success, because github action has different JAVA_HOME environment value

iQQBot · 2022-01-19T17:32:34Z

components/gitpod-protocol/java/BUILD.yaml

@@ -8,8 +8,6 @@ packages:
      - "gradle/wrapper/*"
      - "gradlew"
      - "settings.gradle"
-    env:


move to .werft/build.yaml

iQQBot · 2022-01-19T17:34:40Z

/assign @akosyakov

akosyakov · 2022-01-19T21:36:59Z

.github/workflows/jetbrains-auto-update.yml

@@ -0,0 +1,40 @@
+name: rollout for new JetBrains IDE releases


new -> latest

akosyakov

/lgtm

roboquat · 2022-01-19T21:37:24Z

LGTM label has been added.

Git tree hash: 8fab6e3f970ca30afaf9fd36b251f870513c0569

roboquat · 2022-01-19T21:37:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov

Associated issue: #7023

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [akosyakov]
~~components/gitpod-protocol/java/OWNERS~~ [akosyakov]
~~components/ide/OWNERS~~ [akosyakov]
~~components/supervisor-api/OWNERS~~ [akosyakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

roboquat added release-note-none team: IDE size/M labels Jan 19, 2022

iQQBot force-pushed the pd/improve-rollout-7023 branch from 0304dfa to 02dcbb9 Compare January 19, 2022 15:53

roboquat added size/L and removed size/M labels Jan 19, 2022

iQQBot force-pushed the pd/improve-rollout-7023 branch 2 times, most recently from a8658be to 52ab5f3 Compare January 19, 2022 16:14

iQQBot force-pushed the pd/improve-rollout-7023 branch 4 times, most recently from 05ba428 to 0861961 Compare January 19, 2022 17:01

Automatic rollout latest Jetbrains IDE

cd76a12

iQQBot force-pushed the pd/improve-rollout-7023 branch from 0861961 to cd76a12 Compare January 19, 2022 17:03

iQQBot commented Jan 19, 2022

View reviewed changes

roboquat assigned akosyakov Jan 19, 2022

akosyakov reviewed Jan 19, 2022

View reviewed changes

.github/workflows/jetbrains-auto-update.yml

@@ -0,0 +1,40 @@

name: rollout for new JetBrains IDE releases

Copy link

Member

akosyakov Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new -> latest

akosyakov approved these changes Jan 19, 2022

View reviewed changes

roboquat added the lgtm label Jan 19, 2022

roboquat added the approved label Jan 19, 2022

roboquat merged commit b58cb59 into main Jan 19, 2022

roboquat deleted the pd/improve-rollout-7023 branch January 19, 2022 21:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Automatic rollout latest Jetbrains IDE #7684

Automatic rollout latest Jetbrains IDE #7684

Uh oh!

iQQBot commented Jan 19, 2022

Uh oh!

codecov bot commented Jan 19, 2022 •

edited

Loading

Uh oh!

akosyakov commented Jan 19, 2022

Uh oh!

iQQBot commented Jan 19, 2022

Uh oh!

akosyakov commented Jan 19, 2022

Uh oh!

iQQBot commented Jan 19, 2022 •

edited

Loading

Uh oh!

iQQBot commented Jan 19, 2022

Uh oh!

iQQBot Jan 19, 2022

Uh oh!

iQQBot Jan 19, 2022 •

edited

Loading

Uh oh!

iQQBot Jan 19, 2022

Uh oh!

iQQBot Jan 19, 2022

Uh oh!

iQQBot commented Jan 19, 2022

Uh oh!

akosyakov Jan 19, 2022

Uh oh!

akosyakov left a comment

Uh oh!

roboquat commented Jan 19, 2022

Uh oh!

roboquat commented Jan 19, 2022

Uh oh!

Uh oh!

		@@ -0,0 +1,40 @@
		name: rollout for new JetBrains IDE releases

Automatic rollout latest Jetbrains IDE #7684

Automatic rollout latest Jetbrains IDE #7684

Uh oh!

Conversation

iQQBot commented Jan 19, 2022

Description

Related Issue(s)

How to test

Release Notes

Documentation

Uh oh!

codecov bot commented Jan 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

akosyakov commented Jan 19, 2022

Uh oh!

iQQBot commented Jan 19, 2022

Uh oh!

akosyakov commented Jan 19, 2022

Uh oh!

iQQBot commented Jan 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iQQBot commented Jan 19, 2022

Uh oh!

iQQBot Jan 19, 2022

Choose a reason for hiding this comment

Uh oh!

iQQBot Jan 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iQQBot Jan 19, 2022

Choose a reason for hiding this comment

Uh oh!

iQQBot Jan 19, 2022

Choose a reason for hiding this comment

Uh oh!

iQQBot commented Jan 19, 2022

Uh oh!

akosyakov Jan 19, 2022

Choose a reason for hiding this comment

Uh oh!

akosyakov left a comment

Choose a reason for hiding this comment

Uh oh!

roboquat commented Jan 19, 2022

Uh oh!

roboquat commented Jan 19, 2022

Uh oh!

Uh oh!

codecov bot commented Jan 19, 2022 •

edited

Loading

iQQBot commented Jan 19, 2022 •

edited

Loading

iQQBot Jan 19, 2022 •

edited

Loading