Fix ws-proxy helm chart syntax error #7483
Conversation
|
/werft run with-helm 👍 started the job as gitpod-build-pd-fix-helm-wsproxy.1 |
|
/approve no-issue |
There was a problem hiding this comment.
Hey @iQQBot , can you share how to test in the PR description?
I assume "how" was that the installation is successful, and that workspaces start (they are both good).
But, since I am not 100%, it would be good to get your confirmation. For example, if this is related to the SSH gateway, I am unsure how to test it.
Edit: I confirmed I can start workspaces - https://orange-macaw-vlvx9brs.ws-dev.pd-fix-helm-wsproxy.staging.gitpod-dev.com/
|
@kylos101 before this PR run wert job with helm will failed, so if run with helm is successful the purpose has been achieved |
Thank you! I thought that may be the case, but wanted to double check there wasn't anything else you need to test. |
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iQQBot, kylos101 Associated issue: #7412 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/LGTM |
|
LGTM label has been added. Git tree hash: 3d1e16bf81ece4335104724c364f8b409f4f58ec
|
Description
Fix ws-proxy helm chart syntax error, after #7412
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation