Skip to content

Update VM image #7427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Update VM image #7427

merged 1 commit into from
Jan 4, 2022

Conversation

ArthurSens
Copy link
Contributor

@ArthurSens ArthurSens commented Jan 3, 2022

Description

This PR adds a single commit to the mads/harvester-k3s branch (See related PR: #7272)

It updates the VM image, while changing the VM disk size and type.

We can see that the VM was started from the preview environment, and it has a functional VNC and serial console 🙂
https://harvester.gitpod-dev.com/dashboard/c/local/harvester/kubevirt.io.virtualmachine/preview-as-preview-k3s-img/as-preview-k3s-img#basics

NONE

@mads-hartmann mads-hartmann force-pushed the mads/harvester-k3s branch 2 times, most recently from d2c7070 to 43e34af Compare January 4, 2022 10:46
Base automatically changed from mads/harvester-k3s to main January 4, 2022 11:41
@roboquat roboquat added size/L and removed size/XS labels Jan 4, 2022
Signed-off-by: ArthurSens <[email protected]>
@roboquat roboquat added size/XS and removed size/L labels Jan 4, 2022
@meysholdt
Copy link
Member

Rebased on main because #7272 got merged.

Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@roboquat
Copy link
Contributor

roboquat commented Jan 4, 2022

LGTM label has been added.

Git tree hash: d9c16d05bd42b5757f7b9894346734c0d0bc3c20

@mads-hartmann
Copy link
Contributor

/approve

@roboquat
Copy link
Contributor

roboquat commented Jan 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mads-hartmann

No associated issue. Requirement bypassed by manually added approval.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 26e57e0 into main Jan 4, 2022
@roboquat roboquat deleted the as/preview-k3s-img branch January 4, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants