Skip to content

[payment] added more resilience to GitHub payment endpoint #6813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

JanKoehnlein
Copy link
Contributor

Description

Log errors when reconciling plans with GitHub

Related Issue(s)

Fixes #6531

How to test

I fear this cannot be tested.

Release Notes

NONE

@roboquat roboquat added release-note-none team: webapp Issue belongs to the WebApp team size/XS labels Nov 19, 2021
@JanKoehnlein
Copy link
Contributor Author

I think this is the least we can and should currently do on this issue

@JanKoehnlein JanKoehnlein force-pushed the jk/github-reconcile-plan branch from 5d569e2 to bf3846d Compare November 19, 2021 17:02
@JanKoehnlein
Copy link
Contributor Author

JanKoehnlein commented Nov 20, 2021

/werft run

👍 started the job as gitpod-build-jk-github-reconcile-plan.2

@AlexTugarev
Copy link
Member

AlexTugarev commented Nov 22, 2021

/lgtm

makes sense 👍🏻

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: a204a9e244c10d267efb310bd124d0f2dc06525b

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev

Associated issue: #6531

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 5f1f48e into main Nov 22, 2021
@roboquat roboquat deleted the jk/github-reconcile-plan branch November 22, 2021 09:37
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[payment-endpoint] GitHub integration: reconcilePlan is broken
3 participants