-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[ide] Add VS Code desktop IDE options #6671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
packages: | ||
- name: docker | ||
type: docker | ||
srcs: | ||
- "startup.sh" | ||
- "supervisor-ide-config_stable.json" | ||
deps: | ||
- components/ide/code-desktop/status:app | ||
argdeps: | ||
- imageRepoBase | ||
config: | ||
dockerfile: leeway.Dockerfile | ||
metadata: | ||
helm-component: workspace.desktopIdeImages.codeDesktop | ||
buildArgs: | ||
SUPERVISOR_IDE_CONFIG: supervisor-ide-config_stable.json | ||
image: | ||
- ${imageRepoBase}/ide/code-desktop:${version} | ||
- ${imageRepoBase}/ide/code-desktop:commit-${__git_commit} | ||
- name: docker-insiders | ||
type: docker | ||
srcs: | ||
- "startup.sh" | ||
- "supervisor-ide-config_insiders.json" | ||
deps: | ||
- components/ide/code-desktop/status:app | ||
argdeps: | ||
- imageRepoBase | ||
config: | ||
dockerfile: leeway.Dockerfile | ||
metadata: | ||
helm-component: workspace.desktopIdeImages.codeDesktopInsiders | ||
buildArgs: | ||
SUPERVISOR_IDE_CONFIG: supervisor-ide-config_insiders.json | ||
image: | ||
- ${imageRepoBase}/ide/code-desktop-insiders:${version} | ||
- ${imageRepoBase}/ide/code-desktop-insiders:commit-${__git_commit} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# Copyright (c) 2021 Gitpod GmbH. All rights reserved. | ||
# Licensed under the GNU Affero General Public License (AGPL). | ||
# See License-AGPL.txt in the project root for license information. | ||
|
||
FROM scratch | ||
ARG SUPERVISOR_IDE_CONFIG | ||
COPY --chown=33333:33333 ${SUPERVISOR_IDE_CONFIG} /ide-desktop/supervisor-ide-config.json | ||
COPY --chown=33333:33333 startup.sh components-ide-code-desktop-status--app/status /ide-desktop/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
#!/bin/bash -li | ||
# Copyright (c) 2021 Gitpod GmbH. All rights reserved. | ||
# Licensed under the GNU Affero General Public License (AGPL). | ||
# See License-AGPL.txt in the project root for license information. | ||
|
||
set -euo pipefail | ||
|
||
# kill background jobs when the script exits | ||
trap "jobs -p | xargs -r kill" SIGINT SIGTERM EXIT | ||
|
||
/ide-desktop/status 24000 "$1" "$2" | ||
|
||
echo "Desktop IDE startup script exited" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
packages: | ||
- name: app | ||
type: go | ||
srcs: | ||
- "**/*.go" | ||
- "go.mod" | ||
- "go.sum" | ||
env: | ||
- CGO_ENABLED=0 | ||
- GOOS=linux | ||
deps: | ||
- components/supervisor-api/go:lib | ||
config: | ||
packaging: app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
module github.com/gitpod-io/gitpod/code-desktop/status | ||
|
||
go 1.17 | ||
|
||
require google.golang.org/grpc v1.42.0 | ||
|
||
require github.com/grpc-ecosystem/grpc-gateway/v2 v2.5.0 // indirect | ||
|
||
require ( | ||
github.com/gitpod-io/gitpod/supervisor/api v0.0.0-00010101000000-000000000000 | ||
github.com/golang/protobuf v1.5.2 // indirect | ||
golang.org/x/net v0.0.0-20210405180319-a5a99cb37ef4 // indirect | ||
golang.org/x/sys v0.0.0-20210510120138-977fb7262007 // indirect | ||
golang.org/x/text v0.3.5 // indirect | ||
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 | ||
google.golang.org/genproto v0.0.0-20210617175327-b9e0b3197ced // indirect | ||
google.golang.org/protobuf v1.27.1 // indirect | ||
) | ||
|
||
replace github.com/gitpod-io/gitpod/supervisor/api => ../../../supervisor-api/go // leeway |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: The problem with re-using the same component (
PillLabel
) here is that it's now not clear to the user what's the difference between these labels. Cc @loujaybeesuggestion: Ideally, we should at least use a different style but do not want to push back from merging this as is. We can always iterate and improve this later, as you mentioned in #6485 (comment), since this is out of the scope of this PR. Let's make sure there's a follow up issue if we decide to improve the beta label later. ➿
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this to this issue: #6601 (comment)