Skip to content

Fix intermittent integration test failures #5617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 22, 2021
Merged

Conversation

rl-gitpod
Copy link
Contributor

Description

2 minor changes here.
The most impactful is the ws-proxy change where an active workspace could be deleted from the cache by the stop event of the same workspace id. This can happen in integration testing or via the API, but the UI would prevent this happening in user-land as it waits for the stopped event before allowing another start.

Related Issue(s)

Fixes #5413

How to test

Run the 'TestBackup' test:

go test -count=1 -v -run TestBackup ./...

Prior to these changes it will intermittently fail, but if run multiple times in succession it would fail more 'reliably'.
Now, the following repeated test will succeed:

for i in $(seq 1 10); do go test -count=1 -v -run TestBackup ./...; done

Release Notes

NONE

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #5617 (3264c6c) into main (5ecb8f5) will increase coverage by 13.15%.
The diff coverage is 85.24%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #5617       +/-   ##
===========================================
+ Coverage   19.04%   32.20%   +13.15%     
===========================================
  Files           2       28       +26     
  Lines         168     5136     +4968     
===========================================
+ Hits           32     1654     +1622     
- Misses        134     3329     +3195     
- Partials        2      153      +151     
Flag Coverage Δ
components-blobserve-app 29.31% <ø> (?)
components-local-app-app-linux ?
components-local-app-app-windows ?
components-registry-facade-app 11.63% <0.00%> (?)
components-ws-daemon-app 22.11% <0.00%> (?)
components-ws-proxy-app 69.04% <96.29%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...omponents/registry-facade/pkg/registry/manifest.go 9.65% <0.00%> (ø)
components/ws-daemon/pkg/content/service.go 0.00% <0.00%> (ø)
components/ws-proxy/pkg/proxy/infoprovider.go 60.06% <96.29%> (ø)
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
...omponents/registry-facade/pkg/registry/registry.go 0.00% <0.00%> (ø)
components/ws-proxy/pkg/proxy/workspacerouter.go 81.73% <0.00%> (ø)
components/ws-daemon/pkg/quota/size.go 87.30% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ecb8f5...3264c6c. Read the comment docs.

@rl-gitpod rl-gitpod force-pushed the rl/flaky-test-5413 branch 3 times, most recently from 5359d5b to 28b46b1 Compare September 9, 2021 07:53
@roboquat roboquat added size/L and removed size/M labels Sep 13, 2021
@rl-gitpod rl-gitpod force-pushed the rl/flaky-test-5413 branch 3 times, most recently from 87c67b4 to a1f5a6a Compare September 13, 2021 03:32
@rl-gitpod
Copy link
Contributor Author

/hold

Refactoring to use instance id and adding tests

@roboquat roboquat added size/XXL and removed size/L labels Sep 14, 2021
@rl-gitpod rl-gitpod force-pushed the rl/flaky-test-5413 branch 3 times, most recently from b9a4731 to 3892dc0 Compare September 14, 2021 07:36
@rl-gitpod
Copy link
Contributor Author

rl-gitpod commented Sep 14, 2021

/werft run

👍 started the job as gitpod-build-rl-flaky-test-5413.16

@rl-gitpod
Copy link
Contributor Author

rl-gitpod commented Sep 16, 2021

/werft run

👍 started the job as gitpod-build-rl-flaky-test-5413.18

@rl-gitpod
Copy link
Contributor Author

rl-gitpod commented Sep 17, 2021

/werft run

👍 started the job as gitpod-build-rl-flaky-test-5413.24

@rl-gitpod rl-gitpod force-pushed the rl/flaky-test-5413 branch 2 times, most recently from 31476c1 to 6c9cabd Compare September 17, 2021 02:45
@rl-gitpod
Copy link
Contributor Author

/unhold

@csweichel
Copy link
Contributor

imho the changes could go in like this, but I believe there's a chance to simplify things a little

@rl-gitpod rl-gitpod force-pushed the rl/flaky-test-5413 branch 4 times, most recently from 850a67d to 818767f Compare September 21, 2021 03:02
@csweichel
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: f97190d139ec78a38c579290c1374481b849e556

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #5413

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member

aledbf commented Sep 22, 2021

/werft run

👍 started the job as gitpod-build-rl-flaky-test-5413.34

@aledbf
Copy link
Member

aledbf commented Sep 22, 2021

/werft run

👍 started the job as gitpod-build-rl-flaky-test-5413.35

@aledbf
Copy link
Member

aledbf commented Sep 22, 2021

/werft run

👍 started the job as gitpod-build-rl-flaky-test-5413.36

@roboquat roboquat merged commit a475177 into main Sep 22, 2021
@roboquat roboquat deleted the rl/flaky-test-5413 branch September 22, 2021 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test] TestBackup integration test fails
4 participants