-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix intermittent integration test failures #5617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
581d779
to
04e7059
Compare
Codecov Report
@@ Coverage Diff @@
## main #5617 +/- ##
===========================================
+ Coverage 19.04% 32.20% +13.15%
===========================================
Files 2 28 +26
Lines 168 5136 +4968
===========================================
+ Hits 32 1654 +1622
- Misses 134 3329 +3195
- Partials 2 153 +151
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
5359d5b
to
28b46b1
Compare
87c67b4
to
a1f5a6a
Compare
/hold Refactoring to use instance id and adding tests |
a1f5a6a
to
72109d1
Compare
b9a4731
to
3892dc0
Compare
/werft run 👍 started the job as gitpod-build-rl-flaky-test-5413.16 |
3892dc0
to
892c689
Compare
/werft run 👍 started the job as gitpod-build-rl-flaky-test-5413.18 |
/werft run 👍 started the job as gitpod-build-rl-flaky-test-5413.24 |
31476c1
to
6c9cabd
Compare
/unhold |
imho the changes could go in like this, but I believe there's a chance to simplify things a little |
850a67d
to
818767f
Compare
… up when stopping workspace
818767f
to
3264c6c
Compare
/lgtm |
LGTM label has been added. Git tree hash: f97190d139ec78a38c579290c1374481b849e556
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue: #5413 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/werft run 👍 started the job as gitpod-build-rl-flaky-test-5413.34 |
/werft run 👍 started the job as gitpod-build-rl-flaky-test-5413.35 |
/werft run 👍 started the job as gitpod-build-rl-flaky-test-5413.36 |
Description
2 minor changes here.
The most impactful is the ws-proxy change where an active workspace could be deleted from the cache by the stop event of the same workspace id. This can happen in integration testing or via the API, but the UI would prevent this happening in user-land as it waits for the stopped event before allowing another start.
Related Issue(s)
Fixes #5413
How to test
Run the 'TestBackup' test:
go test -count=1 -v -run TestBackup ./...
Prior to these changes it will intermittently fail, but if run multiple times in succession it would fail more 'reliably'.
Now, the following repeated test will succeed:
for i in $(seq 1 10); do go test -count=1 -v -run TestBackup ./...; done
Release Notes