Skip to content

[git] improved logging in GitHub token verification #4479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

JanKoehnlein
Copy link
Contributor

see #4478

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #4479 (23fff6a) into main (2588d5f) will increase coverage by 7.30%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           main   #4479      +/-   ##
=======================================
+ Coverage      0   7.30%   +7.30%     
=======================================
  Files         0      13      +13     
  Lines         0     616     +616     
=======================================
+ Hits          0      45      +45     
- Misses        0     570     +570     
- Partials      0       1       +1     
Impacted Files Coverage Δ
components/gitpod-cli/cmd/git-token-validator.go 14.28% <0.00%> (ø)
components/gitpod-cli/cmd/sync-await.go 6.25% <0.00%> (ø)
components/gitpod-cli/cmd/root.go 0.00% <0.00%> (ø)
components/gitpod-cli/cmd/await-port.go 4.76% <0.00%> (ø)
components/gitpod-cli/cmd/open.go 4.16% <0.00%> (ø)
components/gitpod-cli/cmd/gitpodRun.go 2.94% <0.00%> (ø)
components/gitpod-cli/cmd/url.go 30.00% <0.00%> (ø)
components/gitpod-cli/cmd/sync-done.go 9.09% <0.00%> (ø)
components/gitpod-cli/cmd/preview.go 30.95% <0.00%> (ø)
components/gitpod-cli/cmd/completion.go 25.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2588d5f...23fff6a. Read the comment docs.

Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@JanKoehnlein
Copy link
Contributor Author

JanKoehnlein commented Jun 11, 2021

/werft run

👍 started the job as gitpod-build-jk-credential-helper-log.1

@JanKoehnlein JanKoehnlein merged commit 84cf4a1 into main Jun 11, 2021
@JanKoehnlein JanKoehnlein deleted the jk/credential-helper-log branch June 11, 2021 11:22
MatthewFagan pushed a commit to trilogy-group/gitpod that referenced this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants