[self-hosted] Set sensitive values via secrets - fixes #3094 #4033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I fetch values via Helm `lookup` calls. This is Helm 3 only compatible. - I do not alter the templates to use the existing secrets, I fetch from them and let gitpod create (possibly redundant) secrets - serverProxyApiKey / db.password / components.server.sessionSecret can be set, added via secret with arbitrary key and are autogenerated otherwise - rabbitmq secret can be set, assuming username and password are keys in the secret - nothing is done for minio secrets because it is a subchart with a April 2021 deprecation warning
|
Putting this in for consideration, I need to properly test all those configurations. |
|
/werft run 👍 started the job as gitpod-build-chart-config-existing-secrets-fork.0 |
added 18 commits
April 22, 2021 12:18
…_config_existing_secrets
cyrilcros
force-pushed
the
chart_config_existing_secrets
branch
from
6422ab4 to
061da1c
Compare
added 3 commits
April 25, 2021 18:24
cyrilcros
force-pushed
the
chart_config_existing_secrets
branch
from
626b492 to
c155b2a
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure the chart via existingSecrets; fixes #3094
lookupcalls. This is Helm 3 only compatible.existingSecretNameand be fine.