Skip to content

[dashboard] fixing layout issues #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2021
Merged

[dashboard] fixing layout issues #3845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions components/dashboard/src/settings/Integrations.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,19 +266,19 @@ function GitProviders() {
 
</div>
</div>
<div className="p-0 my-auto flex flex-col w-3/12">
<div className="p-0 my-auto flex flex-col xl:w-3/12 w-4/12">
<span className="my-auto font-medium truncate overflow-ellipsis">{ap.authProviderType}</span>
<span className="text-sm my-auto text-gray-400 truncate overflow-ellipsis">{ap.host}</span>
</div>
<div className="p-0 my-auto flex flex-col w-2/12">
<div className="p-0 my-auto flex flex-col xl:w-2/12 w-6/12">
<span className="my-auto truncate text-gray-500 overflow-ellipsis">{getUsername(ap.authProviderId) || "–"}</span>
<span className="text-sm my-auto text-gray-400">Username</span>
</div>
<div className="p-0 my-auto flex flex-col w-5/12">
<div className="p-0 my-auto hidden xl:flex xl:flex-col xl:w-5/12">
<span className="my-auto truncate text-gray-500 overflow-ellipsis">{getPermissions(ap.authProviderId)?.join(", ") || "–"}</span>
<span className="text-sm my-auto text-gray-400">Permissions</span>
</div>
<div className="my-auto flex w-1/12 pl-8 mr-4 opacity-0 group-hover:opacity-100">
<div className="my-auto flex w-1/12 mr-4 opacity-0 group-hover:opacity-100 justify-end">
<div className="self-center hover:bg-gray-200 rounded-md cursor-pointer w-8">
<ContextMenu menuEntries={gitProviderMenu(ap)}>
<img className="w-8 h-8 p-1" src={ThreeDots} alt="Actions" />
Expand Down Expand Up @@ -394,7 +394,7 @@ function GitIntegrations() {
<div className="p-0 my-auto flex flex-col w-7/12">
<span className="my-auto truncate text-gray-500 overflow-ellipsis">{ap.host}</span>
</div>
<div className="my-auto flex w-1/12 pl-8 opacity-0 group-hover:opacity-100">
<div className="my-auto flex w-1/12 opacity-0 group-hover:opacity-100 justify-end">
<div className="self-center hover:bg-gray-200 rounded-md cursor-pointer w-8">
<ContextMenu menuEntries={gitProviderMenu(ap)}>
<img className="w-8 h-8 p-1" src={ThreeDots} alt="Actions" />
Expand Down
4 changes: 2 additions & 2 deletions components/dashboard/src/settings/Teams.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ function AllTeams() {
Payment in Progress
</div>
</div>
<div className="my-auto flex w-1/12 pl-8 opacity-0 group-hover:opacity-100">
<div className="my-auto flex w-1/12 opacity-0 group-hover:opacity-100 justify-end">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gtsiolis, I know there is no tester for this change in core :-(
but you can compare the styles with the environment variables page. it's just aligned.

</div>
</div>
)}
Expand All @@ -510,7 +510,7 @@ function AllTeams() {
</div>
)}
</div>
<div className="my-auto flex w-1/12 pl-8 mr-4 opacity-0 group-hover:opacity-100">
<div className="my-auto flex w-1/12 mr-4 opacity-0 group-hover:opacity-100 justify-end">
<div className="self-center hover:bg-gray-200 rounded-md cursor-pointer w-8">
<ContextMenu menuEntries={subscriptionMenu(sub)}>
<img className="w-8 h-8 p-1" src={ThreeDots} alt="Actions" />
Expand Down