Skip to content

[self-hosted] [helm] allow the use of Kubernetes TLS secrets for http-certs #3494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cyrilcros
Copy link

@cyrilcros cyrilcros commented Mar 18, 2021

Hi, I am closing #3199 and opening this instead after adding more stuff on my own git fork...
I just realized I had forgotten about the registry facade which is not a preview anymore; that should now work....

Anyway:

  • fixes kubernetes.io/tls certificate support for certificatesSecret #3183
  • you don't have to package your certificate manually, which helps for cert-manager and other such tools
  • I check if fullchain.pem and privkey.pem are in the certificatesSecret secret; if they are I accept them and ask in the NOTES.txt to switch to using Kubernetes TLS Secret ; otherwise I assume they have tls.crt tls.key.

@cyrilcros cyrilcros force-pushed the kubernetes_tls_fix_NEW branch from 7b2dd5d to 8a2f5a0 Compare March 18, 2021 18:02
@cyrilcros cyrilcros changed the title allow the use of Kubernetes TLS secrets for http-certs [self-hosted] [helm] allow the use of Kubernetes TLS secrets for http-certs Mar 19, 2021
@pkalemba
Copy link

+1 need this :)

@cyrilcros
Copy link
Author

@pkalemba Thanks, I am pretty sure this branch will be superseded by https://github.com/gitpod-io/gitpod/compare/aledbf/proxy2caddy which already uses tls.crt / tls.key.

@stale
Copy link

stale bot commented Jul 18, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jul 18, 2021
@stale stale bot closed this Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution meta: stale This issue/PR is stale and will be closed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubernetes.io/tls certificate support for certificatesSecret
3 participants