Skip to content

[dev] Bump helm to ~3.5.2~ ... #3111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2021
Merged

[dev] Bump helm to ~3.5.2~ ... #3111

merged 3 commits into from
Feb 22, 2021

Conversation

geropl
Copy link
Member

@geropl geropl commented Feb 5, 2021

No description provided.

@geropl geropl requested a review from csweichel February 5, 2021 06:13
@geropl geropl changed the title [dev] Bumpt helm to 3.5.2 [wip][dev] Bumpt helm to 3.5.2 Feb 5, 2021
@geropl
Copy link
Member Author

geropl commented Feb 5, 2021

Looks like somewhere between helm 3.0.3 and 3.5.2 they introduce stricter rules regarding versions:

Error: validation: chart.metadata.version "gpl-bump-helm.1" is invalid

https://werft.gitpod-dev.com/job/gitpod-build-gpl-bump-helm.1#build:chart:helm

@geropl
Copy link
Member Author

geropl commented Feb 5, 2021

Might be caused by this change, shipped as part of 3.5.2 8 hours ago.

Might be worth sth slightly older like 3.5.1 to avoid needing to wait for the fix 🙃

@geropl geropl force-pushed the gpl/bump-helm branch 2 times, most recently from 6480d9a to 03c346b Compare February 5, 2021 06:25
@geropl geropl changed the title [wip][dev] Bumpt helm to 3.5.2 [wip][dev] Bump helm to ~3.5.2~ ... Feb 5, 2021
@geropl
Copy link
Member Author

geropl commented Feb 5, 2021

3.5.1 gives: Error: Invalid Semantic Version 🤦

@geropl geropl force-pushed the gpl/bump-helm branch 5 times, most recently from bf42c8b to 9396156 Compare February 15, 2021 10:46
@geropl
Copy link
Member Author

geropl commented Feb 15, 2021

/werft run

👍 started the job as gitpod-build-gpl-bump-helm.11

@geropl geropl changed the title [wip][dev] Bump helm to ~3.5.2~ ... [dev] Bump helm to ~3.5.2~ ... Feb 15, 2021
Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested with gitpod-k3s Docker image and works as expected.

@geropl geropl merged commit 9ae4251 into master Feb 22, 2021
@geropl geropl deleted the gpl/bump-helm branch February 22, 2021 15:19
pavan-tri pushed a commit to trilogy-group/gitpod that referenced this pull request Apr 28, 2021
* [dev] Bump helm to 3.5.2

* [chart] Use chart version during build

* [dev] Update dev image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants