[supervisor] Terminate reparented processes during shutdown #2920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the same SIGTERM/SIGKILL shutdown mechanism to background processes started in terminals, as we provide to the terminals themselves.
As a consequence, one can now start tasks like:
and expect the Docker daemon to terminate gracefully on workspace shutdown (within the terminal shutdown time: 10 seconds).
This PR also slightly extends the supervisor terminal API and introduces annotations on terminals (user-defined metadata). We now also report the terminal shell's PID.
How does it work
In bash, background processes get disowned when the shell is terminated, and subsequently reparented to their parent process (i.e. supervisor). During supervisor shutdown, we now make the reaper send sigterm to any process that gets reparented to supervisor and is still running. In addition, we explicitly SIGTERM all child processes prior to shutting down. This includes former bash background processes.
How to test