Skip to content

Hide the latest editor warning for stopping or stopped workspaces #18336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Jul 24, 2023

Description

Pick up changes from the community contribution in #16940. Cc @Devansu-Yadav

For more context, see relevant section in How we develop.

Changes summary and walkthrough generated by Copilot

Related Issue(s)

Fixes #11035

How to test

  1. Use Latest for the editor
  2. Open a workspace
  3. Stop a workspace
  4. Notice the latest editor warning is not preset for stopping or stopped workspace

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh
  • with-monitoring

/hold

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jul 24, 2023

Pick up changes from the community contribution in #16940. 🍒

Changes were previously reviewed by @mustard-mh in #16940 (review) but could be worth taking a closer look in case changes are no longer applicable or relevant. 🏓

@gtsiolis gtsiolis marked this pull request as ready for review July 24, 2023 09:21
@gtsiolis gtsiolis requested a review from a team as a code owner July 24, 2023 09:21
@gtsiolis
Copy link
Contributor Author

/unhold

@laushinka
Copy link
Contributor

@gtsiolis Could you rerun the preview? I'll review the PR :)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Aug 9, 2023

@laushinka I rebased the branch to update it, which should re-trigger the preview environment, but I think you can also re-run the preview by re-running the Install Gitpod job, right?

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Aug 9, 2023

heads-up: @laushinka There's seems to be an ongoing issue with creating runners which won't let us spin up a preview environment until it gets resolved, see relevant discussion (internal). Cc @vulkoingim

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Aug 9, 2023

heads-up: @laushinka The issue has been resolved, preview environment is up and running. 💡

https://gt-merge-16940.preview.gitpod-dev.com/workspaces

@gtsiolis gtsiolis requested a review from laushinka August 9, 2023 13:30
@laushinka
Copy link
Contributor

Sorry ended up being swamped. Reviewing now!

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Before Stop Stop
SCR-20230828-mrtf image

@roboquat roboquat merged commit f92950f into main Aug 28, 2023
@roboquat roboquat deleted the gt/merge-16940 branch August 28, 2023 06:17
@mustard-mh
Copy link
Contributor

@Devansu-Yadav Thank you for your contribution! 🧡

@gtsiolis
Copy link
Contributor Author

Thanks for taking a look, @mustard-mh. 🌮

@laushinka
Copy link
Contributor

Thank you for taking it over, @mustard-mh! Sorry, @gtsiolis for dropping the ball 🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the latest editor release warning alert on workspace time out
5 participants