-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Hide the latest editor warning for stopping or stopped workspaces #18336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pick up changes from the community contribution in #16940. 🍒 Changes were previously reviewed by @mustard-mh in #16940 (review) but could be worth taking a closer look in case changes are no longer applicable or relevant. 🏓 |
/unhold |
@gtsiolis Could you rerun the preview? I'll review the PR :) |
b3851d8
to
ed2aca4
Compare
@laushinka I rebased the branch to update it, which should re-trigger the preview environment, but I think you can also re-run the preview by re-running the Install Gitpod job, right? |
heads-up: @laushinka There's seems to be an ongoing issue with creating runners which won't let us spin up a preview environment until it gets resolved, see relevant discussion (internal). Cc @vulkoingim |
heads-up: @laushinka The issue has been resolved, preview environment is up and running. 💡 |
Sorry ended up being swamped. Reviewing now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Devansu-Yadav Thank you for your contribution! 🧡 |
Thanks for taking a look, @mustard-mh. 🌮 |
Thank you for taking it over, @mustard-mh! Sorry, @gtsiolis for dropping the ball 🙏🏽 |
Description
Pick up changes from the community contribution in #16940. Cc @Devansu-Yadav
For more context, see relevant section in How we develop.
Changes summary and walkthrough generated by Copilot
Related Issue(s)
Fixes #11035
How to test
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
/hold