Skip to content

[gitpod-cli] change gp rebuild to gp validate #16867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 17, 2023
Merged

[gitpod-cli] change gp rebuild to gp validate #16867

merged 4 commits into from
Mar 17, 2023

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Mar 15, 2023 •
edited
Loading

Description

[gitpod-cli] change gp rebuild to gp validate

Related Issue(s)

Fixes #16389

How to test

  1. start a workspace in this preview env
  2. try gp rebuild --help it will only show --prebuild and --log flag, and a deprecated tips
  3. try gp validate it should work

Release Notes

[gitpod-cli] change `gp rebuild` to `gp validate`

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-pd-rename-gprebuild.1 because the annotations in the pull request description changed
(with .werft/ from main)

@iQQBot iQQBot marked this pull request as ready for review March 15, 2023 16:37
@iQQBot iQQBot requested a review from a team March 15, 2023 16:37
akosyakov
akosyakov reviewed Mar 15, 2023
View reviewed changes
@iQQBot iQQBot force-pushed the pd/rename-gprebuild branch from dbd8e3d to 561a1e8 Compare March 15, 2023 16:42
@akosyakov
Copy link
Member

@iQQBot please include fix for gitpod-code too in this PR: https://github.com/gitpod-io/gitpod-code/blob/9bca96df9401ae4a74ab4632548cb3c20136fa4e/gitpod-shared/src/validate.ts#L14

@iQQBot iQQBot force-pushed the pd/rename-gprebuild branch from 561a1e8 to e600b73 Compare March 16, 2023 06:17
@iQQBot iQQBot requested a review from a team March 16, 2023 06:17
@iQQBot iQQBot requested a review from gtsiolis as a code owner March 16, 2023 06:17
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team labels Mar 16, 2023
@iQQBot
Copy link
Contributor Author

iQQBot commented Mar 16, 2023 •
edited
Loading

@iQQBot please include fix for gitpod-code too in this PR: https://github.com/gitpod-io/gitpod-code/blob/9bca96df9401ae4a74ab4632548cb3c20136fa4e/gitpod-shared/src/validate.ts#L14

done in gitpod-io/gitpod-code@3b076b9 and e600b73

@iQQBot iQQBot requested a review from mustard-mh March 16, 2023 09:41
geropl
geropl approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as described.

gtsiolis
gtsiolis approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock merging.

akosyakov
akosyakov reviewed Mar 16, 2023
View reviewed changes
mustard-mh
mustard-mh reviewed Mar 16, 2023
View reviewed changes
akosyakov
akosyakov approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

/hold

Please remove rebuilds from the description

mustard-mh
mustard-mh approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[unblock] added hold label in case you want to change it #16867 (comment)

@iQQBot iQQBot force-pushed the pd/rename-gprebuild branch from e600b73 to 0cff917 Compare March 17, 2023 05:42
@iQQBot
Copy link
Contributor Author

iQQBot commented Mar 17, 2023

/unhold

@roboquat roboquat merged commit c0d6fa9 into main Mar 17, 2023
@roboquat roboquat deleted the pd/rename-gprebuild branch March 17, 2023 05:51
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: IDE IDE change is running in production deployed Change is completely running in production labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsiolis gtsiolis gtsiolis approved these changes

@akosyakov akosyakov akosyakov approved these changes

@mustard-mh mustard-mh mustard-mh approved these changes

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/M team: IDE team: webapp Issue belongs to the WebApp team
Projects
🍎 WebApp Team
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review naming + use-cases provided by gp rebuild
6 participants
@iQQBot @akosyakov @gtsiolis @mustard-mh @geropl @roboquat