Skip to content

Add confetti after new onboarding flow #16543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 24, 2023
Merged

Add confetti after new onboarding flow #16543

merged 6 commits into from
Feb 24, 2023

Conversation

selfcontained
Copy link
Contributor

@selfcontained selfcontained commented Feb 23, 2023

Description

  • Updates the Company Website input to accept any string that validates as a url and not use an <input type="url"/>, as it's more restrictive then we'd like. Also updated the placeholder to example.com

  • Adds a ConfettiContextProvider to drop confetti on demand from any component. The end of the new onboarding flow drops confetti now with this change.

image

const { showConfetti } = useConfetti();

// walla, drop confetti
showConfetti();

Confetti will automatically hide after it's all been dropped. You can also manually hide it, or inspect the current status of it's it being shown via additional props returned from the useConfetti() hook.

const { isConfettiShowing, showConfetti, hideConfetti } = useConfetti();
  • 2 new dependencies were added for this PR as well.
    • validator (we're using this on the www website already) to validate a url string
    • react-confetti For confetti dropping. I've set it up to bundle split and lazy load so it's not including in the main bundle.

How to test

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-bmh-onboarding-confetti.1 because the annotations in the pull request description changed
(with .werft/ from main)

@selfcontained selfcontained changed the title Bmh/onboarding-confetti Add confetti after new onboarding flow Feb 23, 2023
@selfcontained selfcontained marked this pull request as ready for review February 24, 2023 00:05
@selfcontained selfcontained requested a review from a team February 24, 2023 00:05
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Feb 24, 2023
@filiptronicek filiptronicek mentioned this pull request Feb 24, 2023
11 tasks
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and works! ✔️

@roboquat roboquat merged commit 63a2d6e into main Feb 24, 2023
@roboquat roboquat deleted the bmh/onboarding-confetti branch February 24, 2023 10:00
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants