Skip to content

[dashboard] user visible rename team->organization #16050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2023
Merged

[dashboard] user visible rename team->organization #16050

merged 1 commit into from
Jan 31, 2023

Conversation

svenefftinge
Copy link
Member

Description

Renames all user visible occurences of the term team to organization

Related Issue(s)

Fixes #

How to test

check the UI and verify that we are talking about organizations everywhere.

Release Notes

teams are now called organizations

Documentation

TODO

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-payment
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@svenefftinge svenefftinge requested a review from a team January 26, 2023 13:23
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-se-rename-team.1 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jan 26, 2023
@easyCZ
Copy link
Member

easyCZ commented Jan 26, 2023

What's the plan for coordinating with docs changes for teams, and billing?

@easyCZ
Copy link
Member

easyCZ commented Jan 26, 2023

As a follow-up, we should also update error messages returned by the APIs which mention Teams, as those are also user facing (these get shown when the request fails)

@svenefftinge
Copy link
Member Author

What's the plan for coordinating with docs changes for teams, and billing?

I'll put this on hold and make sure the rename on docs/website happens in parallel.
Just wanted to get some sort of signal first about the approach to only change the user-facing bit.

/hold

@svenefftinge svenefftinge requested a review from gtsiolis January 26, 2023 13:29
@gtsiolis
Copy link
Contributor

gtsiolis commented Jan 26, 2023 •
edited by werft-gitpod-dev-com bot
Loading

Not sure why, but the previous build[1] failed. 🤷

/werft run with-preview

👍 started the job as gitpod-build-se-rename-team.2
(with .werft/ from main)

@svenefftinge
Copy link
Member Author

preview envs fail because of this.

@svenefftinge
Copy link
Member Author

svenefftinge commented Jan 26, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-se-rename-team.3
(with .werft/ from main)

@svenefftinge svenefftinge mentioned this pull request Jan 26, 2023
Closed
7 tasks
@svenefftinge
Copy link
Member Author

svenefftinge commented Jan 26, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-se-rename-team.4
(with .werft/ from main)

@gtsiolis
Copy link
Contributor

gtsiolis commented Jan 26, 2023 •
edited by werft-gitpod-dev-com bot
Loading

Following the hint[1] (internal) how to run this from @AlexTugarev! 💡

/werft run with-clean-slate-deployment=true recreate-vm=true

👍 started the job as gitpod-build-se-rename-team.5
(with .werft/ from main)

Siddhant-K-code
Siddhant-K-code reviewed Jan 27, 2023
View reviewed changes
Copy link
Member

@Siddhant-K-code Siddhant-K-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, All Projects have a static URL with <team> (i.e. /t/<team>/<project>). Related docs. This should also be changed because in Docs We need to mention the updated slug URL (/o/<org>/<project>).

Related Unchanged Files:

@Siddhant-K-code
Copy link
Member

(not related to this PR): Cookie name from team-selection -> org-selection

@gtsiolis
Copy link
Contributor

gtsiolis commented Jan 27, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-se-rename-team.6
(with .werft/ from main)

@gtsiolis
Copy link
Contributor

@svenefftinge In case you haven't seen this already, I'm getting this error when trying to login.

Screenshot 2023-01-27 at 11 19 23 AM

@svenefftinge
Copy link
Member Author

svenefftinge commented Jan 27, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-se-rename-team.8
(with .werft/ from main)

@svenefftinge
Copy link
Member Author

Currently, All Projects have a static URL with <team> (i.e. /t/<team>/<project>). Related docs. This should also be changed because in Docs We need to mention the updated slug URL (/o/<org>/<project>).

Related Unchanged Files:

I'll look at those URLs as part of #16053

@gtsiolis
Copy link
Contributor

gtsiolis commented Jan 27, 2023 •
edited by werft-gitpod-dev-com bot
Loading

Looking at this now! 👀

gtsiolis
gtsiolis reviewed Jan 27, 2023
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @svenefftinge! 🧙

Left some UX comments below. 🏀

@roboquat roboquat added size/XL and removed size/L labels Jan 27, 2023
@svenefftinge
Copy link
Member Author

svenefftinge commented Jan 27, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-se-rename-team.11
(with .werft/ from main)

@svenefftinge svenefftinge mentioned this pull request Jan 27, 2023
Merged
8 tasks
easyCZ
easyCZ reviewed Jan 31, 2023
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are errors returned from /workspace/gitpod/components/public-api-server/pkg/apiv1/team.go which mention teams. These are returned to API calls from the dashboard, and should be changed also

@easyCZ
Copy link
Member

easyCZ commented Jan 31, 2023

Spoke sync, we'll follow-up on the public-api changes.

@svenefftinge
Copy link
Member Author

/unhold

@roboquat roboquat merged commit b67ae81 into main Jan 31, 2023
@roboquat roboquat deleted the se/rename-team branch January 31, 2023 09:14
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsiolis gtsiolis gtsiolis left review comments

@Siddhant-K-code Siddhant-K-code Siddhant-K-code left review comments

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XL team: webapp Issue belongs to the WebApp team
Projects
🍎 WebApp Team
Status: In Validation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@svenefftinge @easyCZ @gtsiolis @Siddhant-K-code @roboquat