[JetBrains] Replace "Status" by "JetBrains Launcher" and run it in a separate image from IDEs #15308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
felladrin
force-pushed
the
ide/jetbrains-launcher
branch
from
494159a to
ee7ce4c
Compare
felladrin
reviewed
Dec 13, 2022
felladrin
reviewed
Dec 13, 2022
felladrin
force-pushed
the
ide/jetbrains-launcher
branch
2 times, most recently
from
ce4d978 to
add9cd7
Compare
felladrin
changed the title
…ge from IDEs Co-authored-by: Anton Kosyakov <[email protected]> Co-authored-by: Andrea Falzetti <[email protected]>
felladrin
force-pushed
the
ide/jetbrains-launcher
branch
from
add9cd7 to
b69c1df
Compare
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
|
@felladrin and I have tested regular workspaces starting fine, also warmup logs are as expected, we're going to merge this one cc @akosyakov |
felladrin
approved these changes
Dec 13, 2022
akosyakov
reviewed
Dec 13, 2022
| @@ -1,45 +0,0 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
this one we should keep but fix later cc @andreafalzetti @felladrin
There was a problem hiding this comment.
You mean components/ide/jetbrains/launcher/hot-deploy.sh [1]? If so, we kept it.
There was a problem hiding this comment.
no, hot-swap as well, it allows to iterate on jb-launcher within a running workspace
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extracts the
statusprogram from the JB IDE images. We're adding a new image calledjb-launcherand it will make iterating on this logic much faster, avoiding to re-build the images each time.Related Issue(s)
Related to #6740
How to test
Release Notes
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh