[dashboard] display credit usage #15295
Conversation
|
started the job as gitpod-build-sefftinge-prebuilds-workspace-starts-14726.1 because the annotations in the pull request description changed |
| @@ -215,7 +215,7 @@ func (c *Client) GetCustomerByAttributionID(ctx context.Context, attributionID s | |||
| } | |||
|
|
|||
| if len(customers) == 0 { | |||
| return nil, status.Errorf(codes.NotFound, "no team customer found for attribution_id: %s", attributionID) | |||
There was a problem hiding this comment.
unrelated drive-by change
| @@ -2155,7 +2155,7 @@ export class GitpodServerEEImpl extends GitpodServerImpl { | |||
| try { | |||
| customer = (await this.billingService.getStripeCustomer({ attributionId })).customer; | |||
| } catch (e) { | |||
| console.error(e); | |||
There was a problem hiding this comment.
unrelated drive-by change
|
/hold |
svenefftinge
force-pushed
the
sefftinge/prebuilds-workspace-starts-14726
branch
from
7263f4c to
e5f7c59
Compare
| <span className="text-gray-900 dark:text-gray-100">{balance}</span> | ||
| <span className="text-gray-900 dark:text-gray-100"> | ||
| {balance.toLocaleString(undefined, { maximumFractionDigits: 2 })} | ||
| </span> |
There was a problem hiding this comment.
drive-by, fixes #15285
There was a problem hiding this comment.
Thanks! Today I learned about Number.toLocaleString(). 💡
|
/unhold |
| @@ -48,7 +48,7 @@ export default function SelectWorkspaceClass(props: SelectWorkspaceClassProps) { | |||
| {supportedClasses.map((c) => { | |||
| return ( | |||
| <WorkspaceClass | |||
| additionalStyles="w-80 h-32" | |||
| additionalStyles="w-80" | |||
There was a problem hiding this comment.
Unfortunately, removing the fixed height causes the bottom padding to look enormous 😞 but I didn't have a good suggestion for how to get it right without significant changes. So, maybe let's iterate on the design of the workspace class selector in follow-ups.
There was a problem hiding this comment.
by enormous you mean more than what is shown in screenshot in the initial comment?
There was a problem hiding this comment.
I mean the empty vertical space between the dot and the bottom border of the card:
Before
After
There was a problem hiding this comment.
Ah, ok that is intentional. cc @gtsiolis
There was a problem hiding this comment.
Padding changes look (acceptable). ✔️
I'd separate the consumption rate (10 credits/hour) from the resources (dot) indicator (● ●) information to scale better, but can be done along with more spacing improvements later when we introduce more than two workspace classes.
Thanks for the ping, @svenefftinge! 🏓
Thanks for caring about the spacing, @jankeromnes! ✨
roboquat
added
deployed: webapp
Description
Show the amount of credits used per workspace class
Related Issue(s)
Fixes #15275
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh