Skip to content

[dashboard] consistent pay wall #15230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2022
Merged

[dashboard] consistent pay wall #15230

merged 1 commit into from
Dec 8, 2022

Conversation

svenefftinge
Copy link
Contributor

Description

Generalizes the pay wall on start and create ws and changes the link to point to /billing

Related Issue(s)

Fixes #15188

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-payment
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@svenefftinge svenefftinge requested a review from a team December 8, 2022 07:38
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-sefftinge-ubp-improve-pay-wall-15188.1 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added the size/L label Dec 8, 2022
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Dec 8, 2022
@geropl
Copy link
Member

geropl commented Dec 8, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-sefftinge-ubp-improve-pay-wall-15188.2
(with .werft/ from main)

@svenefftinge
Copy link
Contributor Author

svenefftinge commented Dec 8, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-sefftinge-ubp-improve-pay-wall-15188.3
(with .werft/ from main)

@geropl
Copy link
Member

geropl commented Dec 8, 2022

(Code LGTM, but wanted to test as well)

@svenefftinge
Copy link
Contributor Author

svenefftinge commented Dec 8, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-sefftinge-ubp-improve-pay-wall-15188.4
(with .werft/ from main)

@svenefftinge
Copy link
Contributor Author

svenefftinge commented Dec 8, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-sefftinge-ubp-improve-pay-wall-15188.5
(with .werft/ from main)

geropl
geropl approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely
image

@roboquat roboquat merged commit 4bc42fa into main Dec 8, 2022
@roboquat roboquat deleted the sefftinge/ubp-improve-pay-wall-15188 branch December 8, 2022 10:50
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UBP] Improve "pay-wall"
3 participants
@svenefftinge @geropl @roboquat