[UBP] Nudge users toward pay-as-you-go in workspace class preferences #15190

jankeromnes · 2022-12-06T14:04:15Z

Description

Nudge users toward pay-as-you-go in workspace class preferences.

Related Issue(s)

How to test

View some Project's Settings page without being on UBP yet

Release Notes

NONE

Documentation

Werft options:

/werft with-local-preview
If enabled this will build install/preview
/werft with-preview
/werft with-large-vm
/werft with-integration-tests=all
Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

werft-gitpod-dev-com · 2022-12-06T14:13:36Z

started the job as gitpod-build-jx-ws-classes-nudge.1 because the annotations in the pull request description changed
(with .werft/ from main)

jankeromnes · 2022-12-06T15:09:57Z

I've implemented @jldec's latest suggestion here #14831 (comment) because that seemed like an easy first attempt, but I'd also be happy to implement @gtsiolis' Nudge 1 from #14831 (comment) (as agreed to by @svenefftinge)

Not UBP Project Settings	UBP Project Settings

EDIT: Looking a bit closer at it, I find it confusing (what is "my existing plan"? 🤔 and where should I go to cancel it?) -- Maybe the other proposal is better.

jankeromnes · 2022-12-06T15:23:07Z

Will implement Nudge (1) -- back to Draft.

jankeromnes · 2022-12-06T16:20:53Z

I also found & fixed a bug that prevented UBP personal account projects from using workspace classes. 🐛

Okay, new proposal:

	Personal Account	Team
Not UBP	Button links to `/plans`	Button links to Team Billing
UBP

gtsiolis

Thanks, @jankeromnes! 🔮

Left some minor and non-blocking comments below. 🏓

gtsiolis · 2022-12-06T16:43:21Z

components/dashboard/src/projects/ProjectSettings.tsx

@@ -48,12 +49,14 @@ export function ProjectSettingsPage(props: { project?: Project; children?: React

 export default function () {
    const { project, setProject } = useContext(ProjectContext);
-    const [teamBillingMode, setTeamBillingMode] = useState<BillingMode | undefined>(undefined);
+    const [billingMode, setBillingMode] = useState<BillingMode | undefined>(undefined);


issue: Probably not the best line to comment on this, but the Usage tab is visible for teams even if you haven't enabled UBP for your account. Is this known or expected?

Good catch! But yes, I believe this is expected. The reason is that viewing the Usage for your team makes sense even if you're not yet on UBP.

components/dashboard/src/projects/ProjectSettings.tsx

gtsiolis · 2022-12-06T17:18:53Z

components/dashboard/src/projects/ProjectSettings.tsx

+                <h3 className="mt-12">Workspaces</h3>
+                <p className="text-base text-gray-500 dark:text-gray-400">
+                    Choose the workspace machine type for your workspaces.
+                </p>


thought: I find the section heading here unnecessary as if we're trying to fool users by advertizing a feature that does not exist, or they can not reach, especially since there are no other workspace settings, and we're not allowing users to close this alert. I'd drop the section heading, but I'll leave you and @jldec decide because of the relevant comment in #14831 (comment). 🏓

Thanks @gtsiolis. I agree that we wouldn't want to fool our users about anything.

Ping @jldec for final decision about the heading 🙂 🙏

I think it's clearer with the heading Let's leave it in.

DEAL—Let's go with that and change later if needed. 🤝

components/dashboard/src/projects/ProjectSettings.tsx

jankeromnes · 2022-12-07T09:29:39Z

Many thanks for the feedback! Everything is resolved, and this PR is just awaiting approval before it can be merged. 🙂 🔜

jldec · 2022-12-07T09:44:08Z

We’ve introduced complexity into this nudge by adding buttons that link to the right places with the action button.
There are actually 3 different scenarios

personal
team-plan (old)
team-billing (new)

We need to link to all 3 correctly for the buttons to work properly.

jankeromnes · 2022-12-07T09:46:59Z

personal

This is handled ✅ (link to old individual billing)

team-plan (old)

I think this is irrelevant -- we allow users to switch to UBP even if they still have old Team Plans. Please confirm @geropl

team-billing (new)

This is handled ✅ (link to team billing)

jldec · 2022-12-07T09:52:25Z

Please see comment in the issue.

We need to keep the nudge language to explain that cancelling is required.
It's ok to remove the mention of March 2023.

Please use the following Nudge text:

! To access large workspaces and pay-as-you-go, first cancel your existing plan.

It's fine to have the green buttons or links to the right place to cancel, as long as they work properly.

jankeromnes · 2022-12-07T14:43:47Z

Okay, reverted to the billing page nudge, but kept the button:

Also, the Team Billing page now also has a nudge when relevant (new in this PR):

…rences

…active Chargebee team plan, also nudge towards cancelling

svenefftinge

LGTM

roboquat added release-note-none do-not-merge/work-in-progress size/M labels Dec 6, 2022

jankeromnes force-pushed the jx/ws-classes-nudge branch from f17252d to bd82e32 Compare December 6, 2022 14:29

jankeromnes marked this pull request as ready for review December 6, 2022 15:06

jankeromnes requested a review from a team December 6, 2022 15:06

roboquat removed the do-not-merge/work-in-progress label Dec 6, 2022

github-actions bot added the team: webapp Issue belongs to the WebApp team label Dec 6, 2022

jankeromnes marked this pull request as draft December 6, 2022 15:23

roboquat added the do-not-merge/work-in-progress label Dec 6, 2022

jankeromnes force-pushed the jx/ws-classes-nudge branch from bd82e32 to 12e7106 Compare December 6, 2022 16:16

roboquat added size/L and removed size/M labels Dec 6, 2022

jankeromnes marked this pull request as ready for review December 6, 2022 16:20

roboquat removed the do-not-merge/work-in-progress label Dec 6, 2022

jankeromnes force-pushed the jx/ws-classes-nudge branch from 12e7106 to f760f12 Compare December 6, 2022 16:22

gtsiolis reviewed Dec 6, 2022

View reviewed changes

jankeromnes force-pushed the jx/ws-classes-nudge branch from f760f12 to 12139b1 Compare December 7, 2022 08:28

jankeromnes added 2 commits December 7, 2022 14:45

[dashboard] Nudge users toward pay-as-you-go in workspace class prefe…

3dec626

…rences

[dashboard] In Team Billing, if UBP flag is on but you still have an …

71d2f81

…active Chargebee team plan, also nudge towards cancelling

jankeromnes force-pushed the jx/ws-classes-nudge branch from 12139b1 to 71d2f81 Compare December 7, 2022 14:45

svenefftinge approved these changes Dec 7, 2022

View reviewed changes

roboquat merged commit 3b4ffb3 into main Dec 7, 2022

roboquat deleted the jx/ws-classes-nudge branch December 7, 2022 15:20

roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 8, 2022

[UBP] Nudge users toward pay-as-you-go in workspace class preferences #15190

[UBP] Nudge users toward pay-as-you-go in workspace class preferences #15190

Uh oh!

Conversation

jankeromnes commented Dec 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue(s)

How to test

Release Notes

Documentation

Werft options:

Uh oh!

werft-gitpod-dev-com bot commented Dec 6, 2022

Uh oh!

jankeromnes commented Dec 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jankeromnes commented Dec 6, 2022

Uh oh!

jankeromnes commented Dec 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gtsiolis left a comment

Choose a reason for hiding this comment

Uh oh!

gtsiolis Dec 6, 2022

Choose a reason for hiding this comment

Uh oh!

jankeromnes Dec 7, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gtsiolis Dec 6, 2022

Choose a reason for hiding this comment

Uh oh!

jankeromnes Dec 7, 2022

Choose a reason for hiding this comment

Uh oh!

jldec Dec 7, 2022

Choose a reason for hiding this comment

Uh oh!

gtsiolis Dec 7, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jankeromnes commented Dec 7, 2022

Uh oh!

jldec commented Dec 7, 2022 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jankeromnes commented Dec 7, 2022 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jldec commented Dec 7, 2022

Uh oh!

jankeromnes commented Dec 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

svenefftinge left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jankeromnes commented Dec 6, 2022 •

edited

Loading

jankeromnes commented Dec 6, 2022 •

edited

Loading

jankeromnes commented Dec 6, 2022 •

edited

Loading

jldec commented Dec 7, 2022 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Dec 7, 2022 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Dec 7, 2022 •

edited

Loading