[usage] reduce possibility for races in ResetUsage #15006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
approved these changes
Nov 28, 2022
Comment on lines
411
to
418
| cc := &db.CostCenter{ | ||
| ID: db.NewUserAttributionID(uuid.New().String()), | ||
| CreationTime: db.NewVarCharTime(time.Now()), | ||
| SpendingLimit: 500, | ||
| BillingStrategy: db.CostCenter_Stripe, | ||
| }) | ||
| } | ||
|
|
||
| err := conn.Save(cc).Error |
There was a problem hiding this comment.
You could use dbtest.CreateCostCenter.
|
|
||
| now := time.Now().UTC() | ||
|
|
||
| logger.Info("Running `ResetUsage`.") |
There was a problem hiding this comment.
Suggested change
| logger.Info("Running `ResetUsage`.") | |
| logger.WithField("attribution_id", id).WithField("cost_center", cc).Infof("Resetting usage for Attribution ID %s", id) |
There was a problem hiding this comment.
👍 Added the cost center. the attributiond id was already included and I like to keep the message static, as it's a bit easier to filter on that way.
svenefftinge
force-pushed
the
sefftinge/ubp-duplicate-ledger-14973
branch
from
c486546 to
1d53a42
Compare
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fetch the cost center from db immediately before deciding to resetting the usage. So that the time window in which a parallel resetting for the same cost center could happen is minimized.
We saw eight cases in Nopvember where thsi happened. But teh likely hood was very high due to:
Related Issue(s)
Fixes #14973
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh