[server] Change response codes returned from api/feature-flags/slow-database endpoint
#14930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
reviewed
Nov 24, 2022
5 tasks
|
/hold for suggested refactor, up to you if you want to do it |
easyCZ
approved these changes
Nov 24, 2022
|
/unhold |
AlexTugarev
reviewed
Nov 25, 2022
| try { | ||
| if (!User.is(req.user)) { | ||
| res.setHeader("X-Gitpod-Slow-Database", "false"); |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the
api/feature-flags/slow-databasereturn code200and set theX-Gitpod-Slow-Databaseheader consistently.We don't need to distinguish between response codes for the reverse proxy 'pre-flight' added in #14897 and in fact having the endpoint return non-success codes is actively unhelpful when using the Caddy forward_auth directive.
See #14897 (comment) for more context.
Related Issue(s)
Part of #9198
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh