[db-sync] Introduce SyncPeriod (with upper limit now - 5s) #14568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
force-pushed
the
gpl/14560-lost-updates
branch
from
4c81578 to
e895705
Compare
|
/hold For further reviews and testing. |
geropl
changed the title
geropl
force-pushed
the
gpl/14560-lost-updates
branch
from
e895705 to
361fbb8
Compare
|
Did a small change to avoid eating Errors by accident. Will test in staging once the build has finished. |
|
/unhold Testing on staging looking good. |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This intended to be a small and pragmatic fix to db-sync to make it more reliable before we can retire it completely.
Before, it would always sync from ´[previousRun, ...now`. Also, it was using the local processes clock, which is obviously out-of-sync with the DB's.
This PR addresses this by:
Related Issue(s)
Fixes #14560
How to test
leeway build components/gitpod-db:dbtest-init(components/ee/db-sync && yarn db-test)Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh