[werft] Update previews to use analytics token from secret #14511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #14509 Currently, Analytics in preview environments are broken through werft as we need to pass the write key through attributes which means we would leak it. This PR fixes that by instead updating weft to read them from a Kubernetes secret (This is already added into the cluster. See https://github.com/gitpod-io/ops/pull/6614). This means users now enable analytics by using setting `analytics: segment` and we read `segment-staging-write-key` to make it work. This secret is set to the staging segment source right now. Signed-off-by: Tarun Pothulapati <[email protected]>
mads-hartmann
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, Analytics in preview environments are broken through werft as we need to pass the write key through attributes which means we would leak it.
This PR fixes that by instead updating weft to read them from a Kubernetes secret (This is already added into the cluster. See https://github.com/gitpod-io/ops/pull/6614). This means users now enable analytics by using setting
analytics: segmentand we readsegment-staging-write-keyto make it work. This secret is set to the staging segment source right now.Signed-off-by: Tarun Pothulapati [email protected]
Related Issue(s)
Fixes #14509
How to test
Run the following and see analytic events in the
staging trustedsegment source.Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide