Skip to content

[db] Add a deleted column to the d_b_workspace_cluster table #14340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

andrew-farries
Copy link
Contributor

Description

Add a deleted column to the d_b_workspace_cluster table. This will allow rows to be soft-deleted in a follow-up PR.

Related Issue(s)

Part of #9198 and #13800

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@andrew-farries andrew-farries requested a review from a team November 2, 2022 08:16
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 2, 2022
export class AddDeletedColumnToWorkspaceClusterTable1667375160684 implements MigrationInterface {
public async up(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(
"ALTER TABLE d_b_workspace_cluster ADD COLUMN `deleted` tinyint(4) NOT NULL DEFAULT '0'",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR itself LGTM.

💡 Before we start using we need to honor the field in all read queries. But that can happen in a follow-up PR. 👍

@roboquat roboquat merged commit 3139966 into main Nov 2, 2022
@roboquat roboquat deleted the af/soft-deletion-in-workspace-cluster-table branch November 2, 2022 08:26
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants