[usage] Use createStripeSubscription behind feature flag #14332
Conversation
|
started the job as gitpod-build-lau-ff-stripe-13198.2 because the annotations in the pull request description changed |
laushinka
force-pushed
the
lau/ff-stripe-13198
branch
2 times, most recently
from
70a42ae to
2775cfc
Compare
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
laushinka
force-pushed
the
lau/ff-stripe-13198
branch
from
da6df28 to
ca2970c
Compare
| "createStripeSubscriptionOnUsage", | ||
| false, | ||
| { | ||
| user: user, |
There was a problem hiding this comment.
Question: which user/team should we be feature flagging for now?
There was a problem hiding this comment.
I think if you run through the subscription workflow in staging for both a user and a team, and it works through the usage component, then I'd largely go and enable it for all in prod, but monitor.
Adding specific target rules here is mostly for completeness, and for if it does go wrong that we can disable for all but reproduce for our team or something like that.
| "createStripeSubscriptionOnUsage", | ||
| false, | ||
| { | ||
| user: user, |
There was a problem hiding this comment.
We should supply the team_id as well for the case when it's enabled by a team
There was a problem hiding this comment.
Absolutely - will add it.
laushinka
force-pushed
the
lau/ff-stripe-13198
branch
from
ca2970c to
fdbbf7c
Compare
| @@ -2177,6 +2178,7 @@ export class GitpodServerEEImpl extends GitpodServerImpl { | |||
|
|
|||
| const user = this.checkAndBlockUser("subscribeToStripe"); | |||
|
|
|||
| let team: Team | undefined; | |||
| try { | |||
| if (attrId.kind === "team") { | |||
| const team = await this.guardTeamOperation(attrId.teamId, "update"); | |||
There was a problem hiding this comment.
I this that when this is declared as a const it will shadow the let team above and won't actually get assigned
laushinka
force-pushed
the
lau/ff-stripe-13198
branch
from
fdbbf7c to
bd15072
Compare
| } else { | ||
| await this.stripeService.setDefaultPaymentMethodForCustomer(customerId, setupIntentId); | ||
| await this.stripeService.createSubscriptionForCustomer(customerId, attributionId); | ||
| } | ||
|
|
||
| // Creating a cost center for this customer | ||
| const { costCenter } = await this.usageService.setCostCenter({ |
There was a problem hiding this comment.
As a follow-up, we should then move the cost-center setting into the CreateStripeSubscription call
roboquat
added
deployed: webapp
Description
Uses the CreateStripeSubscription RPC behind a feature flag.
Related Issue(s)
Relates #13198
How to test
I tested by:
kubectl port-forward server 9500:9500curl localhost:9500/metricsgitpod_server_stripe_client_requests_completed_duration_secondsmetric.Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide