[db] Add extra assertions to workspace cluster db tests #14323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
approved these changes
Nov 1, 2022
Comment on lines
203
to
209
| const wscs2 = await this.db.findFiltered({ applicationCluster: "us02" }); | ||
| expect(wscs2.length).to.equal(2); | ||
| wscs2.sort((x, y) => x.name.localeCompare(y.name)); | ||
| expect(wscs2[0].name).to.equal("eu71"); | ||
| expect(wscs2[0].applicationCluster).to.equal("us02"); | ||
| expect(wscs2[1].name).to.equal("us71"); | ||
| expect(wscs2[1].applicationCluster).to.equal("us02"); |
There was a problem hiding this comment.
Is it not possible to compare lists directly? That would avoid comparing field-by-field which has the risk of still passing when new fields are added.
There was a problem hiding this comment.
Rebased to change the style of assertions here.
andrew-farries
force-pushed
the
af/extra-assertions-for-ws-cluster-db
branch
from
f2cfc62 to
4def1c3
Compare
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add stronger assertions to the the database tests for the workspace cluster db.
Now that the primary key for the table is a composite of (
name,applicationCluster), add tests that operations work as expected with rows that share the samename.Related Issue(s)
Part of #14136
How to test
unit tests
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide