-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Refactor previewctl install-context
#14241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b71efcb
to
c88a42a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome Aleks. I left a few inline comments.
For a big PR like this I would have loved a PR description that provided more context about the change. Here are a few questions I have that would have been nice to have in the PR description.
- We'll have to bump the version of previewctl in the image (unfortunately). This isn't done in this PR so I'm assuming you'll do it in a follow-up PR.
- With this change we should be able to delete this
- Install-contexts isn't used in any of the Werft jobs yet. What's the plan for using it? It would be nice to be able to delete this and switch any invocations of it like this to use install-context. We should also be able to simplify the Werft job by removing the stateful handling of port-forwarding that install-context now takes care of (e.g. removing this and related code)
Yeah I agree - I just marked it ready for review when I was mostly done with it yesterday and left the description for today. Didn't think that anyone will review it that soon 😄
Yep
Also yes
Will remove this eventually
Will change this later as well
Yeah, we should be able to remove this and the part that copies the context in the job also. Edit: Issue for ☝️ |
c88a42a
to
6ef0475
Compare
6ef0475
to
dcf3c2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛹 🚀
Description
previewctl install-context
command from bash to go and adds testsget-credentials
command, that was introduced recently so it fits better with the new design and adds tests to some of the functions as wellRelated Issue(s)
Fixes https://github.com/gitpod-io/ops/issues/5763
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide