[usage] Setup usage reset job #14189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
force-pushed
the
mp/usage-reset-usage-job-setup
branch
from
d55accc to
a296d51
Compare
andrew-farries
suggested changes
Oct 26, 2022
easyCZ
force-pushed
the
mp/usage-reset-usage-job-setup
branch
from
a296d51 to
54bc3e0
Compare
andrew-farries
approved these changes
Oct 26, 2022
easyCZ
force-pushed
the
mp/usage-reset-usage-job-setup
branch
from
e3f3dbc to
8138015
Compare
4 tasks
|
I would have preferred to call this in the existing ledger job after the sync. I think it's simpler and would also help with making sure the usage for the time we use was reconciled. |
|
@svenefftinge My thinking here is that the usage reset should be lighter weight in terms of compute time and should run more frequently. I wanted to avoid coupling them if we need to adjust the frequency on either without being limited to the runtime of the usage reconcile. But you make a good point. They could run in the same control loop. In either case, we shouldn't assume that the reset runs shortly after usage reconcile as that may not hold true. |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial setup for usage reset job. Currently does nothing but logs when it's triggered.
Config in the installer will be added in subsequent PR.
Related Issue(s)
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide