Unblock Self-Hosted release by introducing UsageServiceMock #14162
Conversation
|
started the job as gitpod-build-gpl-14129-sh-usage.2 because the annotations in the pull request description changed |
geropl
force-pushed
the
gpl/14129-sh-usage
branch
from
35cd093 to
837a53a
Compare
|
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-gpl-14129-sh-usage.4 |
|
/werft run with-preview=true 👍 started the job as gitpod-build-gpl-14129-sh-usage.5 |
| attributionId: AttributionId.render(AttributionId.create(team)), | ||
| }); | ||
| if (costCenter.costCenter?.billingStrategy === CostCenter_BillingStrategy.BILLING_STRATEGY_STRIPE) { | ||
| const billingStrategy = await this.usageService.getCurrentBillingStategy(AttributionId.create(team)); |
There was a problem hiding this comment.
Talking to the usage service here is okay, because we should only reach this stage when isUsageBasedBillingEnabled == true
| if (config.enablePayment) { | ||
| return ctx.container.get<UsageServiceImpl>(UsageServiceImpl); | ||
| } | ||
| return new UsageServiceMock(); |
There was a problem hiding this comment.
[nit] Let's call it a NoOpUsageService or something along the lines. Calling it a mock smells like this is test code.
It's a hack, honestly, but should work for today. We definitely need the |
geropl
force-pushed
the
gpl/14129-sh-usage
branch
from
837a53a to
6da8a9f
Compare
|
Supersede by this PR: #14173 |
Description
Mitigate the fact that usage is not deployed with self-hosted, yet, by mocking it away until we properly fixed it with #14129.
Related Issue(s)
Context: #14129
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide