[usage] Implement CreateStripeSubscription

[laushinka]

Description

Implements CreateStripeSubscription.
Follow-up: Plug it into server with a feature flag.

Related Issue(s)

Depends on #14124
Fixes #13198

How to test

1. Go to the preview env.
2. Create a team with the name Gitpod in it (make sure to use the capital 'G').
3. Go to the team's Billing page.
4. Upgrade plan.

Release Notes

NONE

Documentation

Werft options:

• /werft with-local-preview
  If enabled this will build install/preview
• /werft with-preview
• /werft with-integration-tests=all
  Valid options are all, workspace, webapp, ide

[werft-gitpod-dev-com]

started the job as gitpod-build-lau-createstripesub-impl.9 because the annotations in the pull request description changed
(with .werft/ from main)

[laushinka]

Pipeline has been acting weird.

/werft run

👍 started the job as gitpod-build-lau-createstripesub-impl.24
(with .werft/ from main)

[easyCZ]

Moving this back to draft, we need to clean up a bit and rebase on #14124 before we can land this.

[laushinka]

Ready for the next round of review, but holding to comment out this test line.

/hold

[laushinka]

@easyCZ Changes incorporated. If you don't need the preview anymore, I'll remove the call in the server[1] and put back the original. ✅

[easyCZ]

@easyCZ Changes incorporated. If you don't need the preview anymore, I'll remove the call in the server[1] and put back the original.

I think it might be easier to add the feature flag in this PR such that you don't have to keep test commits around.

[laushinka]

I think it might be easier to add the feature flag in this PR such that you don't have to keep test commits around.

I can understand and will keep that in mind for next tasks, but for this one I would like to have a separate feature flag PR[1] to avoid adding more things into this already big PR which has taken quite some time.

[easyCZ]

Looking great, almost there.

[easyCZ]

Because here you only check the empty string, and return an error. You can increase cohesion of this handling by pushing that error into the getPriceIdentifier. It would look like this:

Suggested change

	priceIdentifier := getPriceIdentifier(attributionID, stripeCustomer, s)
	if priceIdentifier == "" {
	return nil, status.Errorf(codes.InvalidArgument, "Invalid currency %s for customer ID %s", stripeCustomer.Metadata["preferredCurrency"], stripeCustomer.ID)
	}
	priceID, err := getPriceIdentifier(attributionID, stripeCustomer, s)
	if err != nil {
	// note we're not wrapping the error, as the `getPriceIdentifier` can do that for us, with more context on the actual failure.
	return nil, err
	}

The getPriceIdentifier then becomes:

func getPriceIdentifier(attributionID db.AttributionID, stripeCustomer *stripe_api.Customer, s *BillingService) (string, error) {
	preferredCurrency := stripeCustomer.Metadata["preferredCurrency"]
	if stripeCustomer.Metadata["preferredCurrency"] == "" {
		log.
			WithField("stripe_customer_id", stripeCustomer.ID).
			Warn("No preferred currency set. Defaulting to USD")
	}

	entity, _ := attributionID.Values()

	switch entity {
		case db.AttributionEntity_User:
			switch preferredCurrency {
				case "EUR":
					return s.stripePrices.IndividualUsagePriceIDs.EUR, nil
				default:
					return s.stripePrices.IndividualUsagePriceIDs.USD, nil
			}

		case AttributionEntity_Team:
			switch preferredCurrency {
				case "EUR":
					return s.stripePrices.TeamUsagePriceIDs.EUR, nil
				default:
					return s.stripePrices.TeamUsagePriceIDs.USD, nil
			}

		default:
			return "", status.Errorf(codes.InvalidArgument, "Invalid currency %s for customer ID %s", stripeCustomer.Metadata["preferredCurrency"], stripeCustomer.ID)
	}
}

[laushinka]

Thanks this is much better, and good point about returning the error here instead.

[easyCZ]

Nice work @laushinka.

[laushinka]

[laushinka]

Thanks a lot, @easyCZ! Will squash and remove hold.