Skip to content

[code] fix portsView address open twice #13778 #13844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Oct 13, 2022

Description

Related Issue(s)

Fixes #13778

How to test

  • Open workspace with Stable Code in Firefox / Arc Browser in preview env
  • Check if portsView address will NOT open twice

Release Notes

Fix the <kbd>PORTS</kbd> view address opening twice in some browsers

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-hw-stable-port2.1 because the annotations in the pull request description changed
(with .werft/ from main)

@mustard-mh
Copy link
Contributor Author

mustard-mh commented Oct 13, 2022

Oct-13-2022 23-45-29

Works (Firefox)

It takes a lot of time to make PortsView available in Firefox 😞 We should fix it

@mustard-mh mustard-mh marked this pull request as ready for review October 13, 2022 15:46
@mustard-mh mustard-mh requested a review from a team October 13, 2022 15:46
Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit fe5e83c into main Oct 13, 2022
@roboquat roboquat deleted the hw/stable-port2 branch October 13, 2022 15:48
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: code (browser) release-note size/XS team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two browser tabs open when I click a port's address
4 participants