Skip to content

Adjust JetBrains Backend Plugin to work with the new Port Forwarding API #13653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Oct 6, 2022

Description

Now that we have EAP IDEs build 223.6x available in gitpod.io, we need to update the back-end plugin with the support for the new Port Forwarding API.

In the current state of this PR, the plugin compiles and doesn't throw errors, but before setting it as Ready for Review, here's what we need to accomplish:

  • Ensure the usage of port name/description columns is working.
  • Remove the unused function overrides from object: ForwardedPortListener
  • Confirm there's no other way to dispose the forwarded ports listeners (currently we use a map for it).
  • Confirm if ports are removed from the UI when programatically removed.

Related Issue(s)

How to test

  1. Open the preview environment of this PR: https://felladrin-a8c1911845.preview.gitpod-dev.com/
  2. In the account preferences, select the Latest JetBrains IntelliJ IDEA as the editor
  3. (...)

Release Notes

NONE

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-felladrin-port-forwarding.1 because the annotations in the pull request description changed
(with .werft/ from main)

@felladrin felladrin force-pushed the felladrin/port-forwarding branch from 65ca1da to d3bfcda Compare October 7, 2022 13:58
@felladrin
Copy link
Contributor Author

Closed in favor of #13747, due to an issue with old Preview Environments [1].

@felladrin felladrin closed this Oct 11, 2022
@felladrin felladrin deleted the felladrin/port-forwarding branch October 11, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants