-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[usage] Only show notification to team owners #13585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-lau-limit-13187.1 because the annotations in the pull request description changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will likely need to squash commits as the last one is just r
/hold for squash
3ad64b6
to
abfe562
Compare
/werft run 👍 started the job as gitpod-build-lau-limit-13187.4 |
@andrew-farries I think it's not being merged because you have to approve as the change requester 🤔 |
Thanks! A bit annoying that it requires that. I wonder if that's something we can change. |
I think for a smoother workflow it's often best to approve with a '/hold' rather than requesting changes, then the PR author can make the change and merge without waiting for re-review. I probably should have done that here. |
Description
This change only shows usage notifications to team owners.
Related Issue(s)
Fixes #13187
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide