Skip to content

[usage] Only show notification to team owners #13585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented Oct 4, 2022

Description

This change only shows usage notifications to team owners.

Related Issue(s)

Fixes #13187

How to test

  1. Join this team that has reached its usage limit[1].
  2. You should not be able to see the notifications.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-payment
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-lau-limit-13187.1 because the annotations in the pull request description changed
(with .werft/ from main)

@laushinka laushinka changed the title [usage] Only show team owners [usage] Only show notification to team owners Oct 4, 2022
@laushinka laushinka marked this pull request as ready for review October 4, 2022 15:23
@laushinka laushinka requested a review from a team October 4, 2022 15:23
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 4, 2022
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will likely need to squash commits as the last one is just r

/hold for squash

@laushinka
Copy link
Contributor Author

laushinka commented Oct 5, 2022

/werft run

👍 started the job as gitpod-build-lau-limit-13187.4
(with .werft/ from main)

@laushinka
Copy link
Contributor Author

laushinka commented Oct 5, 2022

@andrew-farries I think it's not being merged because you have to approve as the change requester 🤔

@roboquat roboquat merged commit 8a78d1f into main Oct 5, 2022
@roboquat roboquat deleted the lau/limit-13187 branch October 5, 2022 10:19
@laushinka
Copy link
Contributor Author

Thanks! A bit annoying that it requires that. I wonder if that's something we can change.

@andrew-farries
Copy link
Contributor

I think for a smoother workflow it's often best to approve with a '/hold' rather than requesting changes, then the PR author can make the change and merge without waiting for re-review.

I probably should have done that here.

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The usage limit almost reached (80%) notification can be distracting
4 participants